Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PULL REQUEST] Bug fixes: (1) Now check GCClassic History subset regions properly; (2) Use proper restart file paths for dry-run data download (Closes #1039, Closes #1045) #1047

Merged
merged 2 commits into from Dec 7, 2021

Commits on Dec 2, 2021

  1. Bug fix: Restore proper restart file folders in download_data.yml

    We have now restored the correct paths for GEOS-Chem restart files
    in download_data.yml.  This may have been clobbered by a Git merge.
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    0648444 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Bug fix: Now correctly check History diagnostic subset indices

    Interfaces/GCClassic/main.F90:
    - Pass State_Grid to routine History_Init
    
    History/history_mod.F90:
    - History_Init now accepts the State_Grid object and passes it to
      routine History_ReadCollectionData
    - History_ReadCollectionData accepts the State_Grid object.
    - State_Grid%NX and State_Grid%NY are used to error-check the
      values of CollectionSubsetInd(:,C) for each collection C.  For
      lon we ensure that indices are within 1 < index < State_Grid%NX,
      and for lat we ensure that indices are within 1 < index < State_Grid%NY.
    
    NOTE: These updates only affect GEOS-Chem Classic History diagnostics.
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    9ab6931 View commit details
    Browse the repository at this point in the history