[PULL REQUEST] Retire CH4 wetland emissions extension #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CH4 wetland extension based off of Picket-Heaps et al. (2011) is retired here. Users of the methane simulation should now use the more current JPL WetCHARTS emissions (https://doi.org/10.3334/ORNLDAAC/1502) instead. Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
|
GCHP integration tests all pass: ==============================================================================
GCHP: Execution Test Results
Number of execution tests: 3
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_fullchem_benchmark_merra2_c48...............Execute Simulation.....PASS
gchp_fullchem_standard_merra2_c24................Execute Simulation.....PASS
gchp_TransportTracers_geosfp_c24.................Execute Simulation.....PASS
Summary of execution test results:
------------------------------------------------------------------------------
Execution tests passed: 3
Execution tests failed: 0
Execution tests not completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
yantosca
approved these changes
Jan 3, 2022
|
All GEOS-Chem Classic integration tests passed as well. Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 80
Execution tests failed: 0
Execution tests not yet completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%NOTE: Since this should be a zero-diff result as far as the full-chemistry simulations are concerned, we will evaluate this with a 1-day benchmark simulation instead of a 1-month simulation. |
yantosca
added
category: Feature Request
|
Because this was a zero-diff update (as far as benchmark simulations are concerned), we validated with 1-day "fullchem benchmark" simulations for expediency. GCC 13.4.0-alpha.11 (this update) vs. alpha.10 (prior update)
GCHP 13.4.0-alpha.11 vs. alpha.10: Both GCC and GCHP show zero-diffs. We are good to merge. |
|
This PR has been merged into the 13.4.0 development stream and tagged with 13.4.0-alpha.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CH4 wetland extension based off of Picket-Heaps et al. (2011) is retired in this PR. Users of the methane simulation should now use the more current JPL WetCHARTS emissions (https://doi.org/10.3334/ORNLDAAC/1502) instead.
See also HEMCO issue geoschem/HEMCO#122.
This should be implemented with the corresponding HEMCO pull request geoschem/HEMCO#124.