[PULL REQUEST] Bug fix for RH in heterogeneous chemistry

[cdholmes]

RH is in percent but assumed to be fraction 0-1 in some places.
Affects gamma values for NO3 and N2O5, since version 12.6.
Corrected gamma values are lower for sea salt.

Signed-off-by: Christopher Holmes cdholmes@fsu.edu

[yantosca]

This PR has been merged into dev/12.7.0. It will become live in GC 12.7.0, and we will run an internal benchmark to assess the effect of this update.

[cdholmes]

I suggest that this bug fix should also be backported to 12.6. Currently, 12.6.2 still has this unfixed bug and heterogeneous chemistry was one of the headline features of 12.6. I expect that the bugfix will raise O3 over the oceans by a couple ppb.

[yc-chan]

I wonder if we also have to change the description for RH in function N2O5_InorgOrg.

I think the RH variable in the line "eps = 1.5e-1_fp * OCratio + 1.6e-3_fp * RH" has the right unit (%), but the input parameter section still states it is in unitless fraction.

[yantosca]

It is not in our procedure to backport bug fixes to master once a version has been benchmarked and approved. For this reason we issue patch releases (e.g. 12.6.1, 12.6,2, etc.).

[cdholmes]

Bob, That’s what I meant. I think this fix should be released as 12.6.3. Chris Christopher D. Holmes, PhD Earth, Ocean and Atmospheric Science Florida State University http://acgc.eoas.fsu.edu

…

________________________________ From: Bob Yantosca <notifications@github.com> Sent: Tuesday, November 12, 2019 9:57:14 AM To: geoschem/geos-chem <geos-chem@noreply.github.com> Cc: Christopher Holmes <cdholmes@fsu.edu>; Author <author@noreply.github.com> Subject: Re: [geoschem/geos-chem] [PULL REQUEST] Bug fix for RH in heterogeneous chemistry (#124) It is not in our procedure to backport bug fixes to master once a version has been benchmarked and approved. For this reason we issue patch releases (e.g. 12.6.1, 12.6,2, etc.). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/geoschem/geos-chem/pull/124?email_source=notifications&email_token=AAQMLBYX74U4TFUXGAEWIWTQTK74VA5CNFSM4JI5HFXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED2QNEY*issuecomment-552928915__;Iw!5Xm4_O-4tfk!nnQZeLTBXojeV4mgLMWKjt0BmFtXKvDeSbktoSGcpRLzJtaDdB5FU_1uERH-VAA$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAQMLB6RDTJJ7ZJDXFH3P6LQTK74VANCNFSM4JI5HFXA__;!5Xm4_O-4tfk!nnQZeLTBXojeV4mgLMWKjt0BmFtXKvDeSbktoSGcpRLzJtaDdB5FU_1uNwW1Y_E$>.

[yantosca]

I updated the comment in routine N2O5_InorgOrg in this commit: 0cdf070, which has been pushed to dev/12.7.0.

We are including this update in 12.7.0 instead of 12.6.2 or 12.6.3, because this update will change the benchmark results, and therefore should go into a "Y" (feature) version instead of a "Z" (patch) version. We will run an internal benchmark to assess the change that this fix brings in.