Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing J-value diagnostics to GCHP HISTORY.rc #1582

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

msulprizio
Copy link
Contributor

In 13.3.0, new species were added for the aromatic chemistry updates. These new photolysis species were automatically output in GCClassic which uses tokens, but needed to be explicitly added to HISTORY.rc for GCHP.

In 13.3.0, new species were added for the aromatic chemistry updates. These
new photolysis species were automatically output in GCClassic which uses
tokens, but needed to be explicitly added to HISTORY.rc for GCHP.

Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
@msulprizio msulprizio added the topic: Diagnostics Related to output diagnostic data label Jan 6, 2023
@msulprizio msulprizio added this to the 14.1.0 milestone Jan 6, 2023
@msulprizio msulprizio self-assigned this Jan 6, 2023
Copy link
Contributor

@lizziel lizziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only comment is reminder to update CHANGELOG.

Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
@msulprizio
Copy link
Contributor Author

@lizziel Thanks for catching the CHANGELOG omission. I just pushed a commit for that.

@msulprizio msulprizio merged commit 3220fe4 into dev/14.1.0 Jan 10, 2023
@msulprizio msulprizio deleted the bugfix/add-missing-jvalue-diags branch January 10, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: Diagnostics Related to output diagnostic data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants