Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset SPC_ time entry from EFYO to CYS for integration tests and fullchem_benchmark runs #1647

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Feb 8, 2023

This PR does resets EFYO -> CYS time cycle flags (for restart file entry SPC_) in:

  1. GCClassic integration tests
  2. GCHP integration tests
  3. fullchem_benchmark simulations.

This is necessary in order to allow integration tests and benchmark simulations to run when new species are added to a simulation. Missing species will be assigned default background values.

NOTE: This is a kludge in order to get 14.2.0 integration tests running again. We will make the same fix in 14.1.1, which has the updated integration test scrips (which have not yet been merged into 14.2.0).

test/GCClassic/intTestExecute.slurm.sh
test/GCHP/intTestCompile.sh
- Do a sed search and replace for EFYO -> CYS in HEMCO_Config.rc
  in each integration test run directory
- NOTE: We will make the same update in the new integration tests
  in GEOS-Chem 14.1.1

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
run/shared/setupConfigFiles.sh
- Do an sed text replacement from EFYO -> CYS for the SPC_ entry.
  This will ensure that benchmarks run even if species are not found
  in the restart file.  Missing species will be bootstrapped to
  background default values.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added category: Bug Something isn't working topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking labels Feb 8, 2023
@yantosca yantosca added this to the 14.2.0 milestone Feb 8, 2023
@yantosca yantosca self-assigned this Feb 8, 2023
@msulprizio
Copy link
Contributor

@yantosca When implementing this in 14.1.1, I recommend doing the replacement of EFYO with EYS in the run directory creation stage (i.e. after the run directories are created). I found it somewhat confusing when I looked at my integration test files and found that the string hadn't been modified for runs that had not yet executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working topic: Benchmarking and Testing Related to CI, integration tests, or scientific benchmarking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants