-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCHP run directory fixes and improvements #2326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
…ation Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
- Clarifying comments - Moved allow species in restart option to frequently changed settings - Changed criteria for dynamics field entries in ExtData.rc to update based on timestep. Now searches for whitespace+name+whitespace rather than whitespace+name and MetDir. Start of line is still required. - Added end of script message that run is complete - Added check that grid resolution is even - Added checks for runs using mass fluxes* 1. check that stretched grid is off 2. check that input and grid resolutions are evenly divisible 3. check that grid/run resolutions evenly divisible by NX and NY/6 *Checks assume either GEOS-FP or GEOS-IT source for mass fluxes and that C180x180x6 appears in GEOS-IT filename.
0562617
to
5617ef3
Compare
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
yantosca
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lizziel! I'll start bringing this in for 14.4.1.
19 tasks
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #4f71c4a GEOS-Chem submod update: Merge PR #2348 (14.4.0 in CESM updates)
GEOS-Chem #e0e6e2fb0 Merge PR #2326 (GCHP run directory fixes and improvements)
HEMCO #55d27e2 Merge PR #280 (Now use comma-separated list in stale.yml )
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 37515708
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Furthermore, all tests were zero-diff w/r/t PR #2348 except for:
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #212f21a GEOS-Chem submod update: Merge PR #2348 (14.4.0 in CESM updates)
GEOS-Chem #e0e6e2fb0 Merge PR #2326 (GCHP run directory fixes and improvements)
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 37515920
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Furthermore, all tests were zero-diff w/r/t PR #2348. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: Feature Request
New feature or request
topic: GCHP
Related to GCHP only
topic: Run Directories
Related to run directory issues and run directory creation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This update applies minor bug fixes and improvements to GCHP run directories.
ExtData.rc
entry for lightning climatology files (off by default unless using GEOS-IT so does not impact benchmark).setCommonRunSettings.sh
related to domain decomposition, mass fluxes, and stretched grid. The run script will exit with an error prior to executing GCHP if there are problems detected that would cause an issue in MAPL.MetDir
symlink inExtData.rc
file path. Users no longer must haveMetDir
in path which is useful when testing new met inventories.Expected changes
This is a zero diff update for benchmarks. Differences are expected only when using lightning climatology which is off by default in benchmarks.
Reference(s)
None
Related Github Issue
None