Cloud-J error handling #2353
Merged
Cloud-J error handling #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantosca
added
the
topic: Structural Modifications
|
NOTE: Integration tests have been run with Cloud-J at commit: geoschem/Cloud-J@bce8992 All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #1b9dc09 GEOS-Chem submod update: Merge PR #2326 (GCHP rundir improvements)
GEOS-Chem #2e09e5aa6 Merge PR #2353 (Cloud-J error handling )
HEMCO #55d27e2 Merge PR #280 (Now use comma-separated list in stale.yml )
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 37822767
==============================================================================Also, all tests were zero-diff w/r/t the prior PR #2326, except:
|
|
@lizziel: The GCHP build fails with: [ 74%] Building Fortran object src/MAPL/gridcomps/ExtData/CMakeFiles/MAPL.ExtData.dir/ExtData_IOBundleMod.F90.o
/n/holyscratch01/jacob_lab/ryantosca/tests/nodiff/gc2353/GCHP_it/CodeDir/src/GCHP_GridComp/GEOSChem_GridComp/Cloud-J/src/Core/cldj_error_mod.F90:34:23:
34 | __Iam__(msg)
| 1
Error: Unexpected data declaration statement at (1)
/n/holyscratch01/jacob_lab/ryantosca/tests/nodiff/gc2353/GCHP_it/CodeDir/src/GCHP_GridComp/GEOSChem_GridComp/Cloud-J/src/Core/cldj_error_mod.F90:34:49:
34 | __Iam__(msg)
| 1
Error: Parameter ‘msg’ at (1) has not been declared or is a variable, which does not reduce to a constant expression
/n/holyscratch01/jacob_lab/ryantosca/tests/nodiff/gc2353/GCHP_it/CodeDir/src/GCHP_GridComp/GEOSChem_GridComp/Cloud-J/src/Core/cldj_error_mod.F90:55:9:
55 | USE MAPL_Mod
| 1
Fatal Error: Cannot open module file ‘mapl_mod.mod’ for reading at (1): No such file or directory
compilation terminated.
make[2]: *** [src/GCHP_GridComp/GEOSChem_GridComp/Cloud-J/src/Core/CMakeFiles/CloudJ_Core.dir/build.make:88: src/GCHP_GridComp/GEOSChem_GridComp/Cloud-J/src/Core/CMakeFiles/CloudJ_Core.dir/cldj_error_mod.F90.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:10028: src/GCHP_GridComp/GEOSChem_GridComp/Cloud-J/src/Core/CMakeFiles/CloudJ_Core.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs.... |
|
I'll push a fix for this. Sorry about that! |
|
Fix pushed (to Cloud-J). |
This update goes an update to Cloud-J. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
lizziel
force-pushed
the
feature/cloudj_error_handling
branch
from
2145b31
to
c831dbf
Compare
|
All GEOS-Chem Classic integration tests passed; ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #cb9b57c GEOS-Chem submod update: Merge PR #2342 and Cloud-J PR #17
GEOS-Chem #5b3987feb Merge PR #2353 (Cloud-J error handling)
HEMCO #2192e0e HEMCO 3.9.1 release
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 39181866
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Also, all tests were zero-diff w/r/t PR #2342 except:
|
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #6eb1110 GEOS-Chem submod update: Merge PR #2342 and Cloud-J PR #17
GEOS-Chem #5b3987feb Merge PR #2353 (Cloud-J error handling)
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 39182175
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Also, all tests were zero-diff w/r/t PR #2342. |
This was referenced Jul 10, 2024
msulprizio
added a commit
that referenced
this pull request
Jul 19, 2024
We now run a 2x2.5 ModelE2.1 (aka GCAP 2.0) full-chemistry simulation in the GCClassic integration tests. Only one scenario (SSP2-4.5) is evaluated here simply to ensure these future scenario simulations compile and run for 1 hour successfully. I will defer to @ltmurray for guidance on whether additional simulations are needed. The GCAP 2.0 integration test is passing off of 14.4.1, confirming that the fixes in #2342 should have resolved the issues of GCAP 2.0 not working in 14.0.0 (as reported by Lee Murray at IGC11). Sample integration test output: ``` ============================================================================== GEOS-Chem Classic: Execution Test Results GCClassic #c49fcec Submod updates: Merge GEOS-Chem PR #2353 and Cloud-J PR #19 GEOS-Chem #7e4001658 Merge PR #2369 (Fix several issues with satellite diagnostics) HEMCO #2192e0e HEMCO 3.9.1 release Using 24 OpenMP threads Number of execution tests: 29 Submitted as SLURM job: 40462513 ============================================================================== Execution tests: ------------------------------------------------------------------------------ gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS gc_2x25_ModelE2.1_fullchem..........................Execute Simulation....PASS ``` Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR goes with accompanying Cloud-J PR geoschem/Cloud-J#19 which adds return status code to Cloud-J subroutines. The GEOS-Chem PR adds the status code to the argument list of Cloud-J subroutine calls and also adds error handling following the calls.
Expected changes
This is a no diff update.
Reference(s)
None
Related Github Issue
geoschem/Cloud-J#19 (Merge required at the same time as this PR)