Re-enable GeoGig plugin in communityRelease module #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this as per #2216 discussion. The GeoGig module will not compile until changes are made to get it working with SpringMVC. I'll re-open a PR to get GeoGig back into the community modules once it is aligned with the Restlet -> Spring changes |
|
@emerkle826 would it not be better to include geogig on master so that it is handled en-masse with all the non-compiling community modules when #2216 is merged? And we do not know when #2216 will be merged. Until then we can include geogig to detect any other breakage caused by changes on master. I am tempted to reopen but will not do so without your agreement. |
|
@bencaradocdavies Very good point. I believe I over-thought this a bit, trying to be a little too proactive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LocationTech builds for GeoGig seem to be stable again.