[GEOS-8105] WCS 2.0 GetCoverage ignores service level overview policy and disallow reader subsampling #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dromagnoli
reviewed
Apr 21, 2017
| Hints readHints = new Hints(); | ||
| readHints.putAll(hints); | ||
| if(request.getOverviewPolicy() != null) { | ||
| hints.add(new Hints(Hints.OVERVIEW_POLICY, request.getOverviewPolicy())); |
There was a problem hiding this comment.
Wondering if that OverviewPolicy hint should be added to the newly created "readHints" object instead of input "hints"
(hints may be null)
There was a problem hiding this comment.
Yep, good catch, this needs fixing indeed.
… and disallow reader subsampling
aaime
force-pushed
the
wcs_20_no_subsample
branch
from
8a84e72
to
8c5ccb0
Compare
|
Restarting build, it was delayed by the Boundless repo availability issues to the point that Travis killed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.