Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-9255]: promote authkey community module to extension #3609

Merged
merged 3 commits into from Jul 3, 2019

Conversation

mbarto
Copy link
Contributor

@mbarto mbarto commented Jun 24, 2019

Description

Promoting the authkey module to extension.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)

The following are required only for core and extension modules, while they are welcomed, but not required, for community modules:

  • There is a ticket in Jira describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[GEOS-XYZW] Title of the Jira ticket" (export to XML in Jira generates the message in this exact form)
  • New unit tests have been added covering the changes
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks (QA checks results will be reported by travis-ci after opening this PR)
  • Commits changing the UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@aaime
Copy link
Member

aaime commented Jul 3, 2019

Hi @mbarto checked and the changes look good, I've just noticed a small difference in the contents of the packaged zip files:

Selezione_808

As you can see, there is an extra json-20080701.jar file in the ZIP file generated by the PR. Probably not harmful, but wondering, did you double check running the result on a GeoServer (e.g., pick a nightly build, add the zip contents to it, see if everything still works as it is supposed to?)

@mbarto
Copy link
Contributor Author

mbarto commented Jul 3, 2019

Thanks, I will double check the additional jar

@mbarto
Copy link
Contributor Author

mbarto commented Jul 3, 2019

@aaime I made the ext-authkey.xml list more picky, to exclude that additional jar

@aaime
Copy link
Member

aaime commented Jul 3, 2019

Good to go then, at least IMHO :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants