Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate CI build to github actions #4581

Merged
merged 4 commits into from Nov 28, 2020
Merged

Conversation

bradh
Copy link
Contributor

@bradh bradh commented Nov 25, 2020

As requested on the mailing list, migrates most of the Travis CI build activity to Github Actions.

Checklist

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for community modules):

  • [N/A] There is a ticket in Jira describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • [N/A] PR for bug fixes and small new features are presented as a single commit
  • [N/A] Commit message must be in the form "[GEOS-XYZW] Title of the Jira ticket" (export to XML in Jira generates the message in this exact form)
  • The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it.
  • [N/A] New unit tests have been added covering the changes
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks (QA checks results will be reported by travis-ci after opening this PR)
  • [N/A] Commits changing the UI, existing user workflows, or adding new functionality, need to include documentation updates (screenshots, text)
  • [N/A] Commits changing the REST API, or any configuration object, should check if the REST API docs (Swagger YAML files and classic documentation) need to be updated.

@aaime
Copy link
Member

aaime commented Nov 26, 2020

This is great progress! The missing bit here seems to be the packaging build (ensuring we can build the war/bin and the extension zip packages without error).

@bradh
Copy link
Contributor Author

bradh commented Nov 26, 2020

This is great progress! The missing bit here seems to be the packaging build (ensuring we can build the war/bin and the extension zip packages without error).

I think this is done. I've folded the package steps into the oraclejdk11 job (see https://github.com/geoserver/geoserver/pull/4581/checks?check_run_id=1458114425), with a (perhaps optimistic) hope that we can reuse the bits we just built, before removing the -SNAPSHOT jars from the cache.

@bradh
Copy link
Contributor Author

bradh commented Nov 26, 2020

Travis is failing with a ConcurrentModificationException, which looks unrelated. Have kicked that build, but don't think it will be relevant.

@bradh bradh marked this pull request as ready for review November 26, 2020 22:10
@bradh bradh changed the title migrate openjdk11 build to github actions migrate CI build to github actions Nov 26, 2020
@aaime
Copy link
Member

aaime commented Nov 27, 2020

Oh... do you remember where it was? I've recently changed some code related to concurrency (to get higher scalability) and worried that failure might be related.

@bradh
Copy link
Contributor Author

bradh commented Nov 27, 2020

Oh... do you remember where it was? I've recently changed some code related to concurrency (to get higher scalability) and worried that failure might be related.

Security core, maybe.

.github/workflows/linux.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
Copy link
Member

@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaime aaime merged commit 2463372 into geoserver:master Nov 28, 2020
@aaime
Copy link
Member

aaime commented Nov 28, 2020

Squash-merged for ease of backport. Thanks for the hard work, much appreciated!

@bradh bradh deleted the ci_migration branch November 28, 2020 22:23
bradh added a commit to bradh/geoserver that referenced this pull request Nov 28, 2020
* ci: migrate from travis build to github actions

* ci: update documentation to reflect migration away from Travis CI

* ci: migrate jdk8 to github actions

* ci: Update display name for Linux Github Actions
bradh added a commit to bradh/geoserver that referenced this pull request Nov 28, 2020
* ci: migrate from travis build to github actions

* ci: update documentation to reflect migration away from Travis CI

* ci: migrate jdk8 to github actions

* ci: Update display name for Linux Github Actions
@bradh
Copy link
Contributor Author

bradh commented Nov 28, 2020

Added backports to 2.17.x and 2.18.x

mprins added a commit that referenced this pull request Nov 29, 2020
migrate CI build to github actions (#4581)
mprins added a commit that referenced this pull request Nov 29, 2020
migrate CI build to github actions (#4581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants