Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-9882] Graduate params-extractor plugin to supported status #4686

Merged
merged 3 commits into from Feb 5, 2021

Conversation

aaime
Copy link
Member

@aaime aaime commented Jan 29, 2021

Graduation of the params-extractor module.
GSIP here

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or not applicable.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for community modules):

  • There is a ticket in Jira describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[GEOS-XYZW] Title of the Jira ticket" (export to XML in Jira generates the message in this exact form)
  • The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it.
  • New unit tests have been added covering the changes
  • This PR passes all existing unit tests (test results will be reported by Continuous Integration after opening this PR)
  • This PR passes the QA checks (QA checks results will be reported by Continuous Integration after opening this PR)
  • Commits changing the UI, existing user workflows, or adding new functionality, need to include documentation updates (screenshots, text)
  • Commits changing the REST API, or any configuration object, should check if the REST API docs (Swagger YAML files and classic documentation) need to be updated.

@jodygarnett
Copy link
Member

jodygarnett commented Feb 2, 2021

Download instructions page needed for extension, use download_extension directive for correct link across live/stable/extension

Copy link
Member

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update / provide download and install instructions suing download_extension directive.

@aaime
Copy link
Member Author

aaime commented Feb 3, 2021

@jodygarnett install instructions added

@aaime aaime merged commit 8fd0b08 into geoserver:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants