Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-10479] Improve TestWfsPost URL validation #5847

Closed
wants to merge 1 commit into from

Conversation

sikeoka
Copy link
Contributor

@sikeoka sikeoka commented Apr 29, 2022

GEOS-10229

This PR blocks using the ".." sequence in the URL and also reverts some weakening of the URL validation from 5facd7a by adding back validation of the URL protocol, port and path instead of only validating the host.

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@sikeoka sikeoka changed the title [GEOS-10229] Improve TestWfsPost URL validation [GEOS-10479] Improve TestWfsPost URL validation Apr 29, 2022
@sikeoka
Copy link
Contributor Author

sikeoka commented Apr 29, 2022

Closing this one and opening a new PR.

@sikeoka sikeoka closed this Apr 29, 2022
@sikeoka sikeoka deleted the GEOS-10229 branch May 9, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant