Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-10058] Welcome Page Layout #6113

Closed
wants to merge 16 commits into from
Closed

Conversation

jodygarnett
Copy link
Member

@jodygarnett jodygarnett commented Aug 15, 2022

GEOS-10058

See https://github.com/geoserver/geoserver/wiki/GSIP-202 proposal for details

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@jodygarnett
Copy link
Member Author

Sharing draft pull request for feedback.

Notes:

  • Reviewed the the existing CapabilitiesHomePageLinkProvider which was setup to return a component; but in reality the component was always a CapabilitiesHomePagePanel which does not have enough visibility to see ServiceInfo objects. Decided to setup a ServiceDescriptionProvider extension to return a data structure (ServiceDescriptino and ServiceLinkDescription) which can be processed for display. We can deprecate CapabilitiesHomePageLinkProvider when transition is complete.

  • Experimenting with using page properties to include workspace and layer information in URL (ne, ne/roads, ?workspace=ne, ?workspace=ne&layer=roads) so we can share a URL to a workspace's services. The logic for how this is handled in dispatcher is spread out in a number of locations.

Copy link
Contributor

@bradh bradh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mixed thoughts.

jodygarnett and others added 7 commits August 16, 2022 08:27
# Conflicts:
#	src/web/core/src/main/java/org/geoserver/web/CapabilitiesHomePagePanel.java
#	src/web/core/src/main/java/org/geoserver/web/GeoServerHomePage.java
#	src/web/core/src/main/java/org/geoserver/web/ServicesPanel.java
@aaime
Copy link
Member

aaime commented Aug 17, 2022

I was thinking about the last iteration of the home page I've seen yesterday, it looks like it's veering away from the other GeoServer pages in terms of colors, font sizes, shape of the buttons and the like, more than what it was already proposed (colors and font sizes were already a bit off, but the utility buttons at the right somehow managed to bring back some of the feeling).

GeoServer has an active branding guide, voted as part of GSIP-26, which you can find here:
https://github.com/geoserver/geoserver/wiki/GeoServer-Branding
and in particular in this PDF document:
https://github.com/geoserver/geoserver/wiki/GeoServer_BrandingGuide.pdf

Could you please make sure the overall home page is a clear implementation of the guidelines? Visually, it should not be hard to check, login as admin, and verify that switching between the home page and inner pages is a seamless visual experience.

jodygarnett and others added 3 commits August 17, 2022 01:10
- decrease the font-size a little
- use flexbox in stead of display:table
- add hover background
# Conflicts:
#	src/web/core/src/main/java/org/geoserver/web/css/geoserver.css
@jodygarnett
Copy link
Member Author

The branding guide is about logo use and is unaffected…

The font sizes and so on are a mess (too big too bold visually) which Michel is going help clean up with his css experience.

@aaime
Copy link
Member

aaime commented Aug 17, 2022

The branding guide is about logo use and is unaffected…

I think you're making a read of it that's too verbatim. The GeoServer pages have a consistent choice of colors and graphics that form (most of the time) a consistent look, inspired from the logo. The home page of GeoServer needs to reflect that, be consistent.

@jodygarnett jodygarnett mentioned this pull request Aug 19, 2022
11 tasks
@jodygarnett
Copy link
Member Author

Moved to #6122 to track welcome branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants