Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue adding layer when a group is present on TOC #10246

Closed
1 task done
ElenaGallo opened this issue Apr 23, 2024 · 3 comments · Fixed by #10278 or #10284
Closed
1 task done

Issue adding layer when a group is present on TOC #10246

ElenaGallo opened this issue Apr 23, 2024 · 3 comments · Fixed by #10278 or #10284
Assignees
@allyoucanmap @ElenaGallo
Labels
Accepted bug Internal
Milestone
2024.01.00

Comments

@ElenaGallo
Copy link
Contributor

Description

When a group exists in the TOC but is not selected, add a layer via the Add Layer button, a new Default group with the added layer appears in the TOC.

1.mp4

How to reproduce

  • Open a map
  • Create a group on TOC
  • Click on Add Layer button
  • Select layer on Catalog

Expected Result

The layer is added without any groups

Current Result

The added layer is located under a new default group

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@ElenaGallo ElenaGallo added this to the 2024.01.00 milestone Apr 23, 2024
@tdipisa
Copy link
Member

tdipisa commented Apr 23, 2024 •
edited

@ElenaGallo this is a know behavior we have maintained for retro-compatibility with old maps. A new issue will be openend to provide further updates for this in 2024.01.01

@tdipisa tdipisa closed this as completed Apr 23, 2024
@tdipisa tdipisa added question and removed bug labels Apr 23, 2024
@tdipisa tdipisa mentioned this issue Apr 23, 2024
Open
6 tasks
@tdipisa
Copy link
Member

tdipisa commented Apr 23, 2024

@ElenaGallo this is a know behavior we have maintained for retro-compatibility with old maps. A new issue will be openend to provide further updates for this in 2024.01.01

Opened this #10247

@tdipisa tdipisa added bug and removed question labels Apr 24, 2024
@tdipisa tdipisa assigned allyoucanmap and unassigned tdipisa Apr 24, 2024
@tdipisa tdipisa reopened this Apr 24, 2024
@tdipisa
Copy link
Member

tdipisa commented Apr 24, 2024

@allyoucanmap as discussed let's focus on a temporary fix for the specific use case reported in this issue waiting for #10247

allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue May 6, 2024
@allyoucanmap
Fix geosolutions-it#10246 Issue adding layer when a group is present …
6851bc3 
…on TOC
@allyoucanmap allyoucanmap mentioned this issue May 6, 2024
Merged
5 tasks
@allyoucanmap allyoucanmap linked a pull request May 6, 2024 that will close this issue
Fix #10246 Issue adding layer when a group is present on TOC #10278
Merged
5 tasks
MV88 added a commit that referenced this issue May 6, 2024
@allyoucanmap @MV88
Fix #10246 Issue adding layer when a group is present on TOC (#10278)
8bcb6fb 
* Fix #10246 Issue adding layer when a group is present on TOC

* Update web/client/reducers/layers.js

---------

Co-authored-by: Matteo V <matteo.velludini@geosolutionsgroup.com>
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 6, 2024
@ElenaGallo ElenaGallo self-assigned this May 7, 2024
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue May 7, 2024
@allyoucanmap @MV88
Fix geosolutions-it#10246 Issue adding layer when a group is present …
5ec7268 
…on TOC (geosolutions-it#10278)

* Fix geosolutions-it#10246 Issue adding layer when a group is present on TOC

* Update web/client/reducers/layers.js

---------

Co-authored-by: Matteo V <matteo.velludini@geosolutionsgroup.com>
@allyoucanmap allyoucanmap mentioned this issue May 7, 2024
Merged
5 tasks
@allyoucanmap allyoucanmap linked a pull request May 7, 2024 that will close this issue
[Backport 2024.01.xx] Fix #10246 Issue adding layer when a group is present on TOC (#10278) #10284
Merged
5 tasks
tdipisa pushed a commit that referenced this issue May 7, 2024
@allyoucanmap @MV88
Fix #10246 Issue adding layer when a group is present on TOC (#10278) (…
2d4d509 
…#10284)

* Fix #10246 Issue adding layer when a group is present on TOC

* Update web/client/reducers/layers.js

---------

Co-authored-by: Matteo V <matteo.velludini@geosolutionsgroup.com>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

@ElenaGallo ElenaGallo

Labels
Accepted bug Internal
Projects
None yet
Milestone
2024.01.00
4 participants
@tdipisa @MV88 @allyoucanmap @ElenaGallo