Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove big dependencies or limit their usage to selected plugins #1202

Closed
mbarto opened this issue Oct 25, 2016 · 2 comments
Closed

Remove big dependencies or limit their usage to selected plugins #1202

mbarto opened this issue Oct 25, 2016 · 2 comments
Assignees
@mbarto
Labels
enhancement Priority: High
Milestone
R42016

Comments

@mbarto
Copy link
Contributor

mbarto commented Oct 25, 2016

And be sure to put them in separate bundles with require.ensure
Currently we should try to remove / limit:

  • ogc-schemas (4.21Mb)
  • turf (1.95Mb)
  • react-color (1.16Mb)
@mbarto mbarto added this to the 0.4 milestone Oct 25, 2016
@mbarto mbarto self-assigned this Oct 25, 2016
@simboss simboss added the ready label Oct 27, 2016
@offtherailz
Copy link
Member

offtherailz commented Oct 28, 2016 •
edited
Loading

We can update react color to 2.4.0
current (2.0.0)

react-color: 743.53 KB (5.57%)

latest(2.4.0)

react-color: 287.53 KB (2.21%)

Should be compatible with react 14 and 15. We have to try if it works.

@offtherailz
Copy link
Member

Tried with both raster and vector styler, it works even better. I have a pending pull request about color picker improvement. Going to cite this issue in the next commit

offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Oct 28, 2016
@offtherailz
Use version of react-color
4722fd6 
- fixes geosolutions-it#1227
- reduces react color size (geosolutions-it#1202)
- minor fixes to equal interval tool in styler
mbarto pushed a commit that referenced this issue Oct 28, 2016
@offtherailz @mbarto
Fix #1227 Styler - Set default position for components (#1228)
593a5ef 
* Fix #1227 . Set default position for components

This prevent the close event to be called.

* fix also possible errors with multiple color pickers

* Use version of react-color

- fixes #1227
- reduces react color size (#1202)
- minor fixes to equal interval tool in styler

* fixed lint error

* render the color picker in a different place to avoid scroll
@mbarto mbarto added in progress and removed ready labels Oct 28, 2016
mbarto added a commit to mbarto/MapStore2 that referenced this issue Oct 28, 2016
@mbarto
Partially fixes geosolutions-it#1202: created smaller bundles to mini…
e6d4c5f 
…mize big dependencies impact
mbarto added a commit to mbarto/MapStore2 that referenced this issue Nov 4, 2016
@mbarto
Partially fixes geosolutions-it#1202: created smaller bundles to mini…
f25d09e 
…mize big dependencies impact
@mbarto mbarto closed this as completed in be45663 Nov 4, 2016
@ghost ghost removed the pending review label Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbarto mbarto

Labels
enhancement Priority: High
Projects
None yet
Milestone
R42016
Development

No branches or pull requests
3 participants
@simboss @offtherailz @mbarto