Identify maxItems cfg option removed

[pgssimon]

Description

Hi
In one of my localConfig.json I have set maxItems for the Identify plugin

        {
            "name": "Identify",
            "cfg": {
                "showHighlightFeatureButton": true,
                "draggable": false,
                "dock": true,
                "viewerOptions": {
                  "container": "{context.ReactSwipe}"
                },
                "maxItems": 200
            },
            "override": {
                "Toolbar": {
                    "position": 11
                }
            }
        },

However this cfg setting is no longer available, is there a replacement setting that I have missed?

Was removed at this commit...

e68ce42#diff-cb0e46ea9c7290f7a328445a8d05f9d7

This is very important as we are not able to display the correct number of records, for instance in the screenshot below there should be 39 Building Consents...

Cheers
Si

[mbarto]

@pgssimon you are right, it's a regression
@offtherailz we could probably move the missing identify options that were in the plugin config in the mapInfo state, so that they can be overridden by localConfig.json

[offtherailz]

The options originally was get from the graphic component properties.
After the refactoring maps the options with this selector.

MapStore2/web/client/selectors/mapInfo.js

Lines 83 to 88 in b812406

	const identifyOptionsSelector = createStructuredSelector({
	format: generalInfoFormatSelector,
	map: mapSelector,
	point: clickPointSelector,
	currentLocale: currentLocaleSelector
	});

A couple of changes like the followings should restore the possibility to customize maxItems :

const identifyOptionsSelector = createStructuredSelector({
        format: generalInfoFormatSelector,
        map: mapSelector,
        point: clickPointSelector,
        currentLocale: currentLocaleSelector,
+       maxItems: (state) => get(state, "mapInfo.configuration.maxItems", 10);
    });

--> localConfig default state

"mapInfo": {
    "enabled": true, // enabled by default
    "disabledAlwaysOn": false, // if true, disable always on setup
    "configuration": {
      "showEmptyMessageGFI": false // allow or deny the visiibility of message when you have no results from identify request
      "infoFormat": "text/plain" // default infoformat value, other values are "text/html" for text only or "application/json" for properties,
+     "maxItems": 50
    }
  }

This proposed solution supports again to maxItems (even "params" should work) from the state, editing it as documented here here

[pgssimon]

@offtherailz that would be perfect

[tdipisa]

/remind me monday

[reminders]

@tdipisa set a reminder for Sep 28th 2020

[reminders]

👋 @tdipisa,

[myrdstom]

This Github issue has a code suggestion which I have implemented. I am however unsure how exactly to recreate and test it out. Any assistance would be appreciated

[MV88]

Hi @pgssimon I recently tested in DEV and was able to fetch 67 items in a layer

so i am wondering if this issue is still valid

May you double check it?

[MV88]

We would like to reintroduce the maxItems aswell

[pgssimon]

I am currently setting up a new server with MapStore 2020.02.01 will check against that