Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize localConfig.json variables on dev (qa and prod) #7165

Closed
28 of 38 tasks
offtherailz opened this issue Jul 29, 2021 · 13 comments
Closed
28 of 38 tasks

Externalize localConfig.json variables on dev (qa and prod) #7165

offtherailz opened this issue Jul 29, 2021 · 13 comments

Comments

@offtherailz
Copy link
Member

offtherailz commented Jul 29, 2021

Description

List of activities to be performed in order to clean up configuration and leverage the data_dir feature

  • remove references authkey to gs-stable (this repo)
    • remove authkey rule from web/client/configs/localConfig.json
  • investigate how mapstore product adapts if no catalog is available (map viewer, dashboard editor)
    • it works by providing an empty ui that at leas one must be added if one wants to use the services
  • remove references to DEV REST services in proxy settings (this repo)
    • dev server now points to dev-mapstore..., remove this dependency, use localhost:8080 (build/buildConfig.js)
    • create a command to start both back-end and front-end for dev instance
  • update documentation about changes of product above
    • migration guidelines?
    • dev doc
    • update ReadMe.md
    • update training?
    • release procedure - remove parts concerning auth
  • Configure DEV to use data dir with patch files
    • clean up db config and move it in data dir
    • prepare patch rule to set useCors urls for (gs-stable) in the datadir_dev/configs/localConfig.json.patch
    • prepare patch rule to apply authkey changes in the datadir_dev/configs/localConfig.json.patch
    • Set other specific configs for open id auth
      • mapstore-ovr.properties
      • configs/localConfig.json.patch
  • Configure QA to use data dir with patch files
    • clean up db config and move it in data dir
    • prepare patch rule to set useCors urls for (gs-stable) in the datadir_qa/configs/localConfig.json.patch
    • prepare patch rule to apply authkey changes in the datadir_qa/configs/localConfig.json.patch
  • Configure STABLE to use data dir with patch files
    • clean up db config and move it in data dir
    • prepare patch rule to set useCors urls for (gs-stable) in the datadir_release/configs/localConfig.json.patch
    • prepare patch rule to apply authkey changes in the datadir_release/configs/localConfig.json.patch
  • when everything before is done version data_dir settings in https://github.com/geosolutions-it/mapstore-datadir in the three branches
    • DEV will match datadir_dev
    • QA will match datadir_qa
    • STABLE will match datadir_release

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: infrastructure settings

Other useful information

@tdipisa
Copy link
Member

tdipisa commented Sep 13, 2021

@offtherailz is a sync up with @randomorder expected for this?

@tdipisa tdipisa added the QF Quality Friday label Nov 11, 2021
@tdipisa tdipisa modified the milestones: 2021.02.01, 2021.02.02 Dec 9, 2021
@tdipisa tdipisa modified the milestones: 2021.02.02, 2022.01.00 Jan 17, 2022
@tdipisa tdipisa added tmp and removed tmp labels Feb 11, 2022
@tdipisa tdipisa removed this from the 2022.01.00 milestone Mar 4, 2022
@tdipisa
Copy link
Member

tdipisa commented Jul 25, 2022

@offtherailz please put here a comment reporting the current state after the migrations to the new jenkins instance.

@offtherailz
Copy link
Member Author

Yes, actually dev, qa and stable are running on docker, and they all have data-directory configured.
I updated the checkboxes so we can unblock this task.

@offtherailz
Copy link
Member Author

Excluding:

  • Backup / versioning of the data dir (that can be delegated to dev ops)
  • "Remove references for gs-stable to catalog" that needs to be investigated (and the points of configuration about it, and can be done in a separate issue

The rest of the work should be straight forward. We have only to pay attention to documentation and training, to align everything (for the next version, when released).

@tdipisa
Copy link
Member

tdipisa commented Jul 27, 2022

@MV88 please setup a quick call with @offtherailz if you need some clarifications to proceed with this. Thank you so much.

@offtherailz
Copy link
Member Author

I splitted the issue parts to clarify what parts can be postpopned. You can create another issue, or if the investigation gets well keep it in this one.

@MV88
Copy link
Contributor

MV88 commented Jul 27, 2022

@tdipisa @offtherailz

as @randomorder told me dev and qa are sharing the same datadir location

AC

  • We need to have one datadir location per istance in order to accomplish some of the tasks expected in this issue

@randomorder
Copy link
Member

we want to split dev and qa datadirs on the demo instance @ibrahimcengizgeo

@ibrahimcengizgeo
Copy link
Contributor

Hi @randomorder , @tdipisa ,
We'd already split for release env. I split them for dev & qa environment now.

folder structure is:

/home
drwxr-xr-x 4 root root 4.0K Jun 1 12:09 mapstore_release
drwxr-xr-x 5 root root 4.0K Aug 3 10:45 mapstore
drwxr-xr-x 5 root root 4.0K Aug 3 10:47 mapstore_dev
drwxr-xr-x 5 root root 4.0K Aug 3 10:48 mapstore_qa

and docker run commands are with volumes:

for DEV:

docker run --name mapstore_dev --restart unless-stopped
-v /home/jenkins/server.xml:/usr/local/tomcat/conf/server.xml
-v /home/mapstore_dev:/usr/local/tomcat/datadir \

for QA:

docker run --name mapstore_qa --restart unless-stopped
-v /home/jenkins/server.xml:/usr/local/tomcat/conf/server.xml
-v /home/mapstore_qa:/usr/local/tomcat/datadir \

Now, you change what you want under /home/mapstore_dev or /home/mapstore_qa folder, and must deploy in order for the changes made to be affected.
be informed.

@tdipisa
Copy link
Member

tdipisa commented Aug 3, 2022

Thank you @ibrahimcengizgeo. @MV88 please check the above and let @ibrahimcengizgeo if something is still needed. Moving back to Ready.

@tdipisa tdipisa mentioned this issue Aug 3, 2022
9 tasks
@MV88
Copy link
Contributor

MV88 commented Aug 5, 2022

@tdipisa datadir on dev and qa are split and can be used to customize config over the two instances

@MV88
Copy link
Contributor

MV88 commented Aug 8, 2022

@ElenaGallo @tdipisa for QA I have just enabled the config patch that changes the authkeyParamName from authkey to authkey-qa

@marthamareal
Copy link

Issue successfully backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants