Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for adding polygon holes #8436

Closed
4 tasks
offtherailz opened this issue Jul 26, 2022 · 2 comments
Closed
4 tasks

Support for adding polygon holes #8436

offtherailz opened this issue Jul 26, 2022 · 2 comments
Assignees
@offtherailz
Labels
C105-2021-EMSA-CGD New Feature used for new functionalities
Milestone
2023.01.00

Comments

@offtherailz
Copy link
Member

Description

Actually we can edit polygons and multipolygons that has holes. Anyway, there is no way to insert an hole in an existing geometry.
We should provide in DrawSupport the possibility to insert the hole.
MapStore may in the future provide the necessary drawing tools to enable this functionality in its own UI

Acceptance criteria

  • DrawSupport should allow to have a mode for inserting an hole in a geometry.
  • Support for OpenLayers only at the moment.
  • Unit tests will demonstrate the functionality is working (and how it woks)
  • Document the additional options in DrawSupport JSDOC

Other useful information
@offtherailz offtherailz added the New Feature used for new functionalities label Jul 26, 2022
@offtherailz offtherailz self-assigned this Jul 26, 2022
@offtherailz offtherailz removed their assignment Jul 26, 2022
@offtherailz offtherailz mentioned this issue Jul 26, 2022
Merged
12 tasks
offtherailz added a commit that referenced this issue Aug 26, 2022
@offtherailz
#8436 - Draw Support - Add support for hole creation ( #8437)
dc3b4ad
@offtherailz
Copy link
Member Author

This is not testable on UI yet.

@offtherailz
Copy link
Member Author

offtherailz commented Aug 26, 2022 •
edited

moved in next release. Not mandatory for this one

@tdipisa tdipisa added this to the 2023.01.00 milestone Dec 16, 2022
@tdipisa tdipisa closed this as completed Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@offtherailz offtherailz

Labels
C105-2021-EMSA-CGD New Feature used for new functionalities
Projects
None yet
Milestone
2023.01.00
Development

No branches or pull requests
2 participants
@offtherailz @tdipisa