Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date picker to edit time attributes #8745

Closed
1 of 6 tasks
alex-fko opened this issue Oct 28, 2022 · 8 comments
Closed
1 of 6 tasks

Date picker to edit time attributes #8745

alex-fko opened this issue Oct 28, 2022 · 8 comments
Assignees
@ElenaGallo @alex-fko
Labels
Accepted C040-COMUNE_GE-2022-CUSTOM-SUPPORT enhancement
Milestone
2023.01.00

Comments

@alex-fko
Copy link
Contributor

Description

At the moment the date picker is not available when editing a temporal attribute (eg. Dates) and the temporal value must be provided manually. The DatePicker should be included for this to make easier the editing and prevent errors.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

Check the ability to configure additional properties for the date picker to eventually be able to set time and not only date.
@alex-fko alex-fko self-assigned this Oct 28, 2022
alex-fko added a commit to alex-fko/MapStore2 that referenced this issue Nov 3, 2022
@alex-fko
geosolutions-it#8745 Date-time picker for date-time/date/time attribu…
7062d02 
…tes on feature editor.
@alex-fko alex-fko mentioned this issue Nov 3, 2022
Merged
12 tasks
@tdipisa tdipisa added this to the 2022.02.02 milestone Nov 3, 2022
allyoucanmap pushed a commit that referenced this issue Nov 10, 2022
@alex-fko
#8745 Date-time picker for date-time/date/time attributes on feature …
5e653ed 
…editor (#8760)
@tdipisa tdipisa modified the milestones: 2022.02.02, 2023.01.00 Nov 14, 2022
@tdipisa tdipisa mentioned this issue Nov 14, 2022
Closed
1 task
@ElenaGallo ElenaGallo self-assigned this Nov 16, 2022
alex-fko added a commit to alex-fko/MapStore2 that referenced this issue Nov 16, 2022
@alex-fko
geosolutions-it#8745 Date-time picker for date-time/date/time attribu…
a05ce74 
…tes on feature editor (geosolutions-it#8760)

(cherry picked from commit 5e653ed)
@alex-fko alex-fko mentioned this issue Nov 16, 2022
Merged
allyoucanmap pushed a commit that referenced this issue Nov 16, 2022
@alex-fko
Backport #8745 #8808 2022.02.xx-c040 Date-time picker for date-time/d…
6dfa9b5 
…ate/time attributes on feature editor (#8829)

* #8745 Date-time picker for date-time/date/time attributes on feature editor (#8760)

(cherry picked from commit 5e653ed)

* #8808 Modifying test to make it stable (#8819)

(cherry picked from commit 64ebf09)
@ElenaGallo
Copy link
Contributor

ElenaGallo commented Nov 24, 2022 •
edited

Hi @tdipisa, on MapStore DEV and on Genova test i found those issues:

  • The date searched in the quick filter of the attribute tables does not give results
    data-attribute-table

  • When an edited date is saved, the hours return as those present before editing (only the minutes change)

edit-data-attribute-table2

@tdipisa
Copy link
Member

tdipisa commented Nov 24, 2022

@ElenaGallo please specify some more info eg. the name of the dataset you are using an if there is already a test map that can be used for this to reproduce.

@ElenaGallo
Copy link
Contributor

@tdipisa you can use this map: https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/openlayers/42438

@tdipisa
Copy link
Member

tdipisa commented Nov 24, 2022 •
edited

@ElenaGallo I think there is a problem with this dataset. As far as I can see the time is properly set

image

@offtherailz do you have a chance to check that please?

@offtherailz
Copy link
Member

I investigated on MapStore possible bugs a lot, but then I noticed that Date is in Date format (without hours), while Time is full iso string.
This doesn't happens in GML response. It looks an issue of GeoServer.

GML:

https://gs-stable.geosolutionsgroup.com/geoserver/mapstore/ows?service=WFS&version=1.0.0&request=GetFeature&typeName=mapstore%3ATypes&maxFeatures=50

offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Nov 25, 2022
@offtherailz
geosolutions-it#8745 Fixed date/time/date-time editor for feature grid
b54e708
@offtherailz offtherailz mentioned this issue Nov 25, 2022
Merged
12 tasks
@offtherailz
Copy link
Member

I found several issues in editing, so I had to fix them all. Moreover I made the editor robust enough to read the date also in the wrong format provided by GeoServer.

@tdipisa
Copy link
Member

tdipisa commented Nov 29, 2022

@offtherailz thank you so muck. Just pay attention to this.

@offtherailz
Copy link
Member

Ok @tdipisa . I've seen "2022.02.xx-c040" in the title of the PR linked and I was confused. Thank you for correcting me 👍

allyoucanmap pushed a commit that referenced this issue Nov 30, 2022
@offtherailz
#8745 Fixed date/time/date-time editor for feature grid (#8844)
5cda66d
offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Nov 30, 2022
@offtherailz
geosolutions-it#8745 Fixed date/time/date-time editor for feature grid (
0a26d39 
geosolutions-it#8844)
@offtherailz offtherailz mentioned this issue Nov 30, 2022
Merged
tdipisa pushed a commit that referenced this issue Nov 30, 2022
@offtherailz
#8745 Fixed date/time/date-time editor for feature grid (#8844) (#8850)
9c3a8e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@alex-fko alex-fko

Labels
Accepted C040-COMUNE_GE-2022-CUSTOM-SUPPORT enhancement
Projects
None yet
Milestone
2023.01.00
Development

No branches or pull requests
4 participants
@offtherailz @tdipisa @ElenaGallo @alex-fko