Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some layers from timeline #8767

Closed
2 of 15 tasks
offtherailz opened this issue Nov 3, 2022 · 3 comments · Fixed by #8823
Closed
2 of 15 tasks

Exclude some layers from timeline #8767

offtherailz opened this issue Nov 3, 2022 · 3 comments · Fixed by #8823

Comments

@offtherailz
Copy link
Member

offtherailz commented Nov 3, 2022

Description

To avoid a lot of layers in the timeline, some layers can be configured to not appear in timeline, even if syncronized with time selected.
If you have a lot of data with the same dates, this will simplify the visualization (10 layers with the same point may show 10 lines in the timeline, all with the same points, the UI is redundant).

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Acceptance criteria

  • Prepare a mockup first
  • As a user, if a layer has a time dimension, I can hide it from timeline settings tool. The timeline settings panel has a new "layers" panel. in this panel you can see the list of layers. Each layer has a checkbox,
    • By default every checkbox is checked. This means that the layer is visible in the timeline.
    • If the checkbox is unchecked the layer disappears from the timeline.
    • If I check the checkbox, the layer appears again in the timeline.
    • The guide layer can not be hidden.
    • At least one layer must stay on the timeline.
    • Anyway the layers will all be in sync with the current time, even if hidden.
    • If I save the map and reload, the status of the checkboxes must be persisted.
@dsuren1
Copy link
Contributor

dsuren1 commented Nov 7, 2022

@offtherailz
Basic mockup of the layer selector in timeline settings. Kindly let me know if needs some refinement.

time_layers

@offtherailz
Copy link
Member Author

ok @dsuren1 keep in mint to

  • store the hidden ones list (new layers should be visible by defalut)
  • make the it scrollable when the layers when overflows.

@dsuren1
Copy link
Contributor

dsuren1 commented Nov 15, 2022

Updated
image

dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 16, 2022
@tdipisa tdipisa linked a pull request Dec 2, 2022 that will close this issue
6 tasks
tdipisa pushed a commit that referenced this issue Dec 6, 2022
* #8767: Show/hide layers from timeline

* Revert config

* Layer settings model change
@tdipisa tdipisa linked a pull request Dec 6, 2022 that will close this issue
12 tasks
@tdipisa tdipisa removed a link to a pull request Dec 6, 2022
12 tasks
@tdipisa tdipisa reopened this Dec 16, 2022
@ElenaGallo ElenaGallo self-assigned this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants