Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp to ground also for polygons to improve 3D feature styling #9067

Closed
7 of 12 tasks
tdipisa opened this issue Mar 31, 2023 · 0 comments · Fixed by #9074, #9073, #9077, #9078 or #9082
Closed
7 of 12 tasks

Clamp to ground also for polygons to improve 3D feature styling #9067

tdipisa opened this issue Mar 31, 2023 · 0 comments · Fixed by #9074, #9073, #9077, #9078 or #9082
Assignees
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted C040-COMUNE_GE-2022-SUPPORT enhancement
Milestone

Comments

@tdipisa
Copy link
Member

tdipisa commented Mar 31, 2023

Description

It should be possible to apply the Clamp to ground option not only to the ountline in order to have a better control of volumes styling (features with 3 dims availables). That's possible introducing the support in MS of perPositionHeight option.

Now, without support of perPositionHeight

image

After, supporting perPositionHeight

image

The Clamp to ground option should be applied to both line and polygon:

  • If it is false it should be like in the screenshot above and Polygon type should be disabled
  • While if it is true both polygon and line must be clamped on the surface of the terrain or 3D Tiles

As a further improvement to make more clear involved options and values, it is requested to change:

  • Clamp outline to ground to simply Clamp to ground
  • Polygon type to Clamp to ground reference
    • and 3D value to 3D Tiles
  • move "Clamp to ground reference" below "Clamp to ground"

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

Sample data can be found here.

@tdipisa tdipisa added the 3D All issues related to the 3D rendering in CesiumJs label Mar 31, 2023
@tdipisa tdipisa added this to the 2023.01.01 milestone Mar 31, 2023
@tdipisa tdipisa self-assigned this Mar 31, 2023
@tdipisa tdipisa removed this from the 2023.01.01 milestone Mar 31, 2023
@tdipisa tdipisa changed the title Clamp to ground also for polygon to improve 3D feature styling Clamp to ground also for polygons to improve 3D feature styling Mar 31, 2023
@tdipisa tdipisa added this to the 2023.01.01 milestone Apr 3, 2023
@tdipisa tdipisa assigned MV88 and unassigned tdipisa Apr 4, 2023
MV88 added a commit to MV88/MapStore2 that referenced this issue Apr 4, 2023
MV88 added a commit to MV88/MapStore2 that referenced this issue Apr 4, 2023
… rule

# Conflicts:
#	web/client/components/styleeditor/config/blocks.js
#	web/client/components/styleeditor/config/property.js
#	web/client/translations/data.it-IT.json
tdipisa pushed a commit that referenced this issue Apr 5, 2023
…ranch) (#9074)

* Fix #9067 clamp to ground changes for 3d tiles in Fill rule

# Conflicts:
#	web/client/components/styleeditor/config/blocks.js
#	web/client/components/styleeditor/config/property.js
#	web/client/translations/data.it-IT.json

* adjusted clamp props and disabled property

* fix un needed change

* fix test

* fix failing test
tdipisa pushed a commit that referenced this issue Apr 5, 2023
…c040 branch (#9073)

* Fix #9067 clamp to ground changes for 3d tiles in Fill rule

* Update web/client/utils/styleparser/CesiumStyleParser.js

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>

* fix test

---------

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>
@tdipisa tdipisa added Accepted and removed Accepted labels Apr 5, 2023
@ElenaGallo ElenaGallo assigned tdipisa and ElenaGallo and unassigned tdipisa Apr 5, 2023
MV88 added a commit to MV88/MapStore2 that referenced this issue Apr 6, 2023
@MV88 MV88 mentioned this issue Apr 6, 2023
12 tasks
tdipisa pushed a commit that referenced this issue Apr 6, 2023
* #9067 Fix translations

* fix ita locale
MV88 added a commit to MV88/MapStore2 that referenced this issue Apr 6, 2023
* geosolutions-it#9067 Fix translations

* fix ita locale
# Conflicts:
#	web/client/translations/data.de-DE.json
#	web/client/translations/data.en-US.json
#	web/client/translations/data.es-ES.json
#	web/client/translations/data.fr-FR.json
#	web/client/translations/data.it-IT.json
@tdipisa tdipisa linked a pull request Apr 6, 2023 that will close this issue
12 tasks
@tdipisa tdipisa linked a pull request Apr 6, 2023 that will close this issue
tdipisa pushed a commit that referenced this issue Apr 6, 2023
* #9067 Fix translations

* fix ita locale
# Conflicts:
#	web/client/translations/data.de-DE.json
#	web/client/translations/data.en-US.json
#	web/client/translations/data.es-ES.json
#	web/client/translations/data.fr-FR.json
#	web/client/translations/data.it-IT.json
MV88 added a commit to MV88/MapStore2 that referenced this issue Apr 7, 2023
… rule (master branch) (geosolutions-it#9074)

* Fix geosolutions-it#9067 clamp to ground changes for 3d tiles in Fill rule

# Conflicts:
#	web/client/components/styleeditor/config/blocks.js
#	web/client/components/styleeditor/config/property.js
#	web/client/translations/data.it-IT.json

* adjusted clamp props and disabled property

* fix un needed change

* fix test

* fix failing test
MV88 added a commit to MV88/MapStore2 that referenced this issue Apr 7, 2023
tdipisa pushed a commit that referenced this issue Apr 7, 2023
…in Fill rule (#9082)

* Fix #9067 clamp to ground changes for 3d tiles in Fill rule (master branch) (#9074)

* Fix #9067 clamp to ground changes for 3d tiles in Fill rule

# Conflicts:
#	web/client/components/styleeditor/config/blocks.js
#	web/client/components/styleeditor/config/property.js
#	web/client/translations/data.it-IT.json

* adjusted clamp props and disabled property

* fix un needed change

* fix test

* fix failing test

* #9067 Fix translations (#9077)

* #9067 Fix translations

* fix ita locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment