Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline crash if time layer has few data #9075

Closed
1 task done
offtherailz opened this issue Apr 5, 2023 · 0 comments · Fixed by #9076
Closed
1 task done

Timeline crash if time layer has few data #9075

offtherailz opened this issue Apr 5, 2023 · 0 comments · Fixed by #9076
Assignees
@offtherailz @ElenaGallo
Labels
Accepted bug C070-CGG-2022-DEV Regression
Milestone
2023.01.01

Comments

@offtherailz
Copy link
Member

offtherailz commented Apr 5, 2023 •
edited
Loading

Description

If a layer do not have any data, the timline shows
"nan-nan-nan" in date fields.
If you try to expand the timeline, it crashes

How to reproduce

(the original test was a little different. I had a context configured for the timeline with a custom resource access manager that filters the data. For users with no data access, the app crashes when timeline is expanded. Anyway I think it could happen in similar conditions like the ones following. To check).

  • Create a time layer on geoserver with 0, 1, or 2 features (GeoServer needs WMTS mutlidim extension to work with timeline)
  • Add the layer to the map
  • Expand the timeline

Expected Result

  • No data shown

Current Result

  • NaN values in current date fields

  • The application crashes

  • Not browser related

Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@offtherailz offtherailz added the bug label Apr 5, 2023
@offtherailz offtherailz added this to the 2023.01.01 milestone Apr 5, 2023
@offtherailz offtherailz changed the title Timeline chrash if time layer has no data inside Timeline crash if time layer has no data inside Apr 5, 2023
@offtherailz offtherailz changed the title Timeline crash if time layer has no data inside Timeline crash if time layer has no data Apr 5, 2023
@tdipisa tdipisa assigned offtherailz and unassigned tdipisa Apr 5, 2023
offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Apr 5, 2023
@offtherailz
Fix geosolutions-it#9075. Handle cases when domain isnot in format st…
339ae4e 
…art--end
@offtherailz offtherailz mentioned this issue Apr 5, 2023
Merged
12 tasks
@offtherailz offtherailz changed the title Timeline crash if time layer has no data Timeline crash if time layer has few data Apr 5, 2023
dsuren1 added a commit that referenced this issue Apr 6, 2023
@offtherailz @dsuren1
Fix #9075. Handle cases when domain isnot in format start--end (#9076)
5e3c57e 
* Fix #9075. Handle cases when domain isnot in format start--end

* Update web/client/epics/timeline.js

---------

Co-authored-by: Suren <dsuren1@gmail.com>
offtherailz added a commit to offtherailz/MapStore2 that referenced this issue Apr 6, 2023
@offtherailz @dsuren1
Fix geosolutions-it#9075. Handle cases when domain isnot in format st…
9be3251 
…art--end (geosolutions-it#9076)

* Fix geosolutions-it#9075. Handle cases when domain isnot in format start--end

* Update web/client/epics/timeline.js

---------

Co-authored-by: Suren <dsuren1@gmail.com>
@offtherailz offtherailz mentioned this issue Apr 6, 2023
Merged
tdipisa pushed a commit that referenced this issue Apr 6, 2023
@offtherailz @dsuren1
Fix #9075. Handle cases when domain isnot in format start--end (#9076) (
9f7884f 
#9079)

* Fix #9075. Handle cases when domain isnot in format start--end

* Update web/client/epics/timeline.js

---------

Co-authored-by: Suren <dsuren1@gmail.com>
@ElenaGallo ElenaGallo self-assigned this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@offtherailz offtherailz

@ElenaGallo ElenaGallo

Labels
Accepted bug C070-CGG-2022-DEV Regression
Projects
None yet
Milestone
2023.01.01
Development

Successfully merging a pull request may close this issue.

Fix #9075. Handle cases when domain isnot in format start--end offtherailz/MapStore2
3 participants
@offtherailz @tdipisa @ElenaGallo