Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to import/export an application context #9248

Closed
4 tasks
dsuren1 opened this issue Jun 26, 2023 · 8 comments · Fixed by #9270
Closed
4 tasks

Ability to import/export an application context #9248

dsuren1 opened this issue Jun 26, 2023 · 8 comments · Fixed by #9270

Comments

@dsuren1
Copy link
Contributor

dsuren1 commented Jun 26, 2023

Description

Ability to import/export an application context from the context manager UI

Acceptance criteria

  • The implementation expects to improve the context manager UI
    • Add import & export button on context wizard. While import is disabled in steps > 1 with a tooltip saying To import a context, go to Step 1
    • Export button is disabled on the new context when basic info is missing
    • All the configured plugin and customized configurations of the plugins including mapConfig and other information that are saved within the context must be exported too
    • Name is not replaced when importing a context json. It is retained, if any, from the context in open

Mock

Import/export in Context wizard
image

Other useful information

georchestra/mapstore2-georchestra#584

@dsuren1 dsuren1 added this to the 2023.02.00 milestone Jun 26, 2023
@dsuren1 dsuren1 self-assigned this Jun 26, 2023
@dsuren1
Copy link
Contributor Author

dsuren1 commented Jun 26, 2023

@tdipisa

Clarifications required

@dsuren1
Copy link
Contributor Author

dsuren1 commented Jun 27, 2023

@tdipisa Shall we close #8173 in favour of this issue?

@tdipisa
Copy link
Member

tdipisa commented Jun 27, 2023

yes

@tdipisa
Copy link
Member

tdipisa commented Jun 27, 2023

@tdipisa

Clarifications required

This is not part of this issue since it is not included in the expected effort as a feature to be supported.

  • Should this be implemented as part of this issue. Alternatively, after discussion with @offtherailz , we believe adding this to option to layer setting, to configure a url rather than during import or export. As this will reduce complicating import/export feature (Maybe in a separate issue?)

Both options could be valid. Maybe the one suggested by @offtherailz is better but we should evaluate the best/more convenient one to be implemented as part of a separate issue and not as part of this first delivery. Properly set sources using relative URLs, where possible, is already a valid possibility.

  • Import/export button placement

    • Discussion with @offtherailz , the suggested location of the import/export is placing it in the context wizard

That's ok for me to have:

  • The export one in the context item inside the contest catalog page
  • The import one just beside the "new context" button on top or, maybe better, directly inside the context wizard as part of the existing toolbar at the bottom. Let's evaluate in the preliminary design phase.

@dsuren1
Copy link
Contributor Author

dsuren1 commented Jun 28, 2023

Mock

Import in Context wizard
image

Export on context card
image

@offtherailz
Copy link
Member

offtherailz commented Jun 28, 2023

For conformity and usability, I should put import and export buttons both in context edit wizard. It is simple to find and use.

Having it on the card is a plus. I personally prefer to NOT have it, because:

  • It is not strictly necessary. We already have this in the context editor.
  • There is no way to use the export outside the context manager, so on the card is a little out of context.

The only "Pros" of having it on the card is that it makes easy to export many context in a few clicks directly in the manager.

Personally I don't think this use case is so frequent to justify the feature.

@dsuren1
Copy link
Contributor Author

dsuren1 commented Jun 28, 2023

Updated

@offtherailz Kindly confirm if the placement of the buttons is okay?

Import/export in Context wizard
image

@offtherailz
Copy link
Member

Correct. Please update the acceptance criteria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants