Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MS background layers using GS OSM ones #9361

Closed
1 of 6 tasks
tdipisa opened this issue Aug 28, 2023 · 8 comments · Fixed by #9360, #9374 or #9376
Closed
1 of 6 tasks

Update MS background layers using GS OSM ones #9361

tdipisa opened this issue Aug 28, 2023 · 8 comments · Fixed by #9360, #9374 or #9376

Comments

@tdipisa
Copy link
Member

tdipisa commented Aug 28, 2023

Description

By default the MS viewer should provide GeoSolutions OSM background (see this demo map). The list of current background should be also reviewed to remove unnecessary ones (eg. OpenTopoMap and NASAGIBS Night 2012).

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: configuration update for background layers

Other useful information

@ElenaGallo
Copy link
Contributor

@tdipisa I noticed that when opening a new map, the OSM Bright background is highlighted in the background selector but OSM is visible in the viewer

backgound.mp4

@tdipisa
Copy link
Member Author

tdipisa commented Sep 6, 2023

@ElenaGallo the pending PR here already handle this fix. Thank you.

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 7, 2023
@ElenaGallo
Copy link
Contributor

@tdipisa with the new default background, when 3D mode is activated, for the first time, the background is not visible.

backgound_on_3D.mp4

@tdipisa
Copy link
Member Author

tdipisa commented Sep 8, 2023

@ElenaGallo I don't know if it is related. I will ask for a check, thank you.

@tdipisa
Copy link
Member Author

tdipisa commented Sep 19, 2023

@ElenaGallo can you please open a new dedicate issue for this?

@ElenaGallo
Copy link
Contributor

@tdipisa The new issue is: #9464

@tdipisa
Copy link
Member Author

tdipisa commented Oct 16, 2023

Waiting for GS MAPS update before proceeding with the backport.

@tdipisa tdipisa reopened this Nov 3, 2023
@tdipisa tdipisa modified the milestones: 2023.02.01, 2023.02.02 Nov 3, 2023
@tdipisa tdipisa modified the milestones: 2023.02.02, 2024.01.00 Jan 10, 2024
@tdipisa
Copy link
Member Author

tdipisa commented Feb 16, 2024

This will land directly in 2024.01.00. GS MAPS update scheduled during February with @randomorder.

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 6, 2024
@tdipisa tdipisa closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment