#9932: On Binary dashboard public dashboard have + button #10277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - fix showing add dashboard button for guest users
mahmoudadel54
added
bug
Internal
BackportNeeded
1 task
offtherailz
previously approved these changes
May 6, 2024
offtherailz
reviewed
May 6, 2024
offtherailz
approved these changes
May 6, 2024
|
@ElenaGallo please test in dev and let us know for the backport (to be done/merged after upcoming 2024.01.00 on stable branch 2024.01.xx) |
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
May 9, 2024
@ElenaGallo |
tdipisa
pushed a commit
that referenced
this pull request
May 10, 2024
tdipisa
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of not hiding add dashboard button for guest users if dashboard view only.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9932
What is the current behavior?
#9932
What is the new behavior?
For guest users, if dashboard has view mode only, it will be hidden
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information