Fixed #1126 : click on import data reloads the imports list #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
requested changes
Oct 11, 2016
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| const ON_STARTUP = 'ON_STARTUP'; |
There was a problem hiding this comment.
Too generic string, call it MANAGER_ITEM_SELECTED
|
|
||
| const ON_STARTUP = 'ON_STARTUP'; | ||
|
|
||
| function onStartUp(toolId) { |
There was a problem hiding this comment.
The function should be called something like itemSelected
offtherailz
approved these changes
Oct 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when you click on import data the imports list is reloaded coming back to the initial state.