Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow appending to existing search results #1159

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Allow appending to existing search results #1159

merged 2 commits into from
Oct 18, 2016

Conversation

manisandro
Copy link
Contributor

This allows having multiple search result providers feed results into the state.

@simboss simboss added the ready label Oct 17, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.571% when pulling 265e436 on sourcepole:append_search_results into ffbaac9 on geosolutions-it:master.

mbarto
mbarto suggested changes Oct 17, 2016
View reviewed changes
Copy link
Contributor

@mbarto mbarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test cases?

@manisandro
Copy link
Contributor Author

Argh typo, I'll push-force an update.

@manisandro
Copy link
Contributor Author

-> done

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 80.588% when pulling 671fb70 on sourcepole:append_search_results into 9e3ad2a on geosolutions-it:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 80.588% when pulling 671fb70 on sourcepole:append_search_results into 9e3ad2a on geosolutions-it:master.

@mbarto mbarto merged commit 8e22fd8 into geosolutions-it:master Oct 18, 2016
@manisandro manisandro deleted the append_search_results branch October 18, 2016 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarto mbarto mbarto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manisandro @coveralls @mbarto @simboss