Add possibility to pass custom options to search action #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
reviewed
Oct 24, 2016
| @@ -38,7 +38,8 @@ let SearchBar = React.createClass({ | |||
| blurResetDelay: React.PropTypes.number, | |||
| typeAhead: React.PropTypes.bool, | |||
| searchText: React.PropTypes.string, | |||
| style: React.PropTypes.object | |||
| style: React.PropTypes.object, | |||
| displaycrs: React.PropTypes.string | |||
There was a problem hiding this comment.
Are you using this in a custom search action? Probably we could just introduce a generic searchOptions object (where you can put crs and other stuff if you need them) to be passed through to the action. What do you think?
There was a problem hiding this comment.
Yep makes sense, done.
manisandro
force-pushed
the
crs_search_action
branch
from
2659bb5
to
faaaab5
Compare
manisandro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement a coordinate search which can search in the currently specified coordinate system, the search handler needs to know the current CRS.