Also store pixel position in state.mousePosition

[manisandro]

Useful i.e. to display a hover tooltip in an "on-the-fly" identify mode.

[mbarto]

Please add tests

[mbarto]

I would copy coordinates also in this case, instead of storing Leaflet objects

[manisandro]

Should I also change other places in the leaflet/Map.jsx which use event.containerPoint (and even event.latlng), i.e. in the singleclick or contextmenu handlers?

[mbarto]

it would be useful, but only if it doesn't take you too much time

[manisandro]

That's the smaller part, the bigger part is figuring out how to write a useful test about this ;)

[coveralls]

Coverage decreased (-0.009%) to 79.722% when pulling c517f9f on sourcepole:mousepos_pixel into baaa7d4 on geosolutions-it:master.

[coveralls]

Coverage remained the same at 79.731% when pulling 83d6ad3 on sourcepole:mousepos_pixel into baaa7d4 on geosolutions-it:master.

[manisandro]

I haven't found a way to add a sensible test for this. I suppose a proper test would be simulating a mouse move event and checking that the i.e. mouseMove event handler gets called with object one expects. However I can't find a way to simulate a mousemove event, below does not work:

it('check that mouse position information is stored on mouse move', () => {
    const testHandlers = {
        onMouseMove: (mousePosition) => { return mousePosition; }
    };
    let spy = expect.spyOn(testHandlers, 'onMouseMove');

    const map = ReactDOM.render(
        <LeafletMap id="mymap" center={{y: 40.0, x: 10.0}} zoom={10} onMouseMove={testHandlers.onMouseMove} />,
        document.getElementById("container")
    );
    expect(map).toExist();

    ReactTestUtils.Simulate.mouseMove(document.getElementById("container"), {clientX: 0, clientY: 0, screenX: 0, screenY: 0});
    expect(spy.calls.length).toBe(1);
});

[coveralls]

Coverage remained the same at 80.016% when pulling 21fe12f on sourcepole:mousepos_pixel into b5b3eb1 on geosolutions-it:master.