Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #814 : cleaned up the viewer css #1237

Merged
merged 3 commits into from
Nov 3, 2016

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Nov 2, 2016

fix #814

  • Moved into related css files the part of the viewer css
  • Moved some css code in the theme

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 79.69% when pulling 669a039 on MV88:iss814-css-viewer-cleanup into 8e628c8 on geosolutions-it:master.

@@ -0,0 +1,6 @@
#mapstore-globalspinner {
margin: 0 !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are !important needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will remove them as soon as we will have a new theme to switch


.react-draggable .panel-heading {
.react-draggable .draggable-header {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be included in the theme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@@ -7,7 +7,7 @@
*/
const React = require('react');

require('../assets/css/viewer.css');
// require('../assets/css/viewer.css');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you removed it, there are still some classes specific for the product viewer, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restoring it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, this is not needed in Maps.jsx, you can remove it

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 79.788% when pulling c564c3b on MV88:iss814-css-viewer-cleanup into 8e628c8 on geosolutions-it:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 79.779% when pulling 9e71837 on MV88:iss814-css-viewer-cleanup into 8e628c8 on geosolutions-it:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some css for viewer is applied only on product
3 participants