Fix #1314 Support to print vector layer #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support vector style for leaflet layers - Conversion to OL2 style format - add reprojectGeoJson utility method to CoordinateUtils Missing: - Print preview support - Markers
- Now you can print also markers - Now the preview shows the vector layer **note**: a little bug have to be solved. The preview map do not show features on first rendering. This can be avoided loading them in the VectorLayer on startup, but this will cause duplicated vectors data.
offtherailz
changed the title
mbarto
reviewed
Dec 5, 2016
| shouldComponentUpdate(newProps) { | ||
| // the reduce returns true when a prop is changed | ||
| // optimizing when options are equal ignorning loading key | ||
| return !(["map", "type", "srs", "position", "zoomOffset", "onInvalid", "onClick", "options"].reduce( (prev, p) => { |
There was a problem hiding this comment.
Do you have a use case where the layer was slow without this?
There was a problem hiding this comment.
I noticed an increase of performances during debug, with many features in the map.
There was a problem hiding this comment.
Honestly, I did not tested if it is perceptible in the normal application, but when you have both map and print preview (doubling in fact the number of features) it can become slow.
There was a problem hiding this comment.
Can I go on with merge?
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Dec 6, 2016
…it#1317) * Fix geosolutions-it#1314 Support to print vector layer (leaflet) - Support vector style for leaflet layers - Conversion to OL2 style format - add reprojectGeoJson utility method to CoordinateUtils Missing: - Print preview support - Markers * Add default marker and preview for vector print - Now you can print also markers - Now the preview shows the vector layer **note**: a little bug have to be solved. The preview map do not show features on first rendering. This can be avoided loading them in the VectorLayer on startup, but this will cause duplicated vectors data. * fixed preview issues for same named layer * ForceUpdate when layer's created. Optimized leaflet layer rendering * rounded reprojection coordinates tests * add tests for feature and vector layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes PDF support for vector layers (OpenLayers) #1315 too, because I created a style abstraction that can be used in every map.