Ensure openlayers mapinfo state is immediately updated as soon as component mounted #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manisandro
force-pushed
the
openlayers_mapstate_update
branch
from
e059cb0
to
fda2105
Compare
mbarto
approved these changes
Dec 13, 2016
This was referenced Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a zoomToExtent call in the app setup logic, and one opens the app in a background tab, it can happen that zoomToExtent throws an exception in MapUtils.js@defaultGetZoomForExtent due to mapSize being null. mapSize is set in openlayers/Map.jsx@map.on('moveend'), but the first call to this event handler may happen too late because browsers often pause/slow down js execution in background tabs.
This PR ensures that the map info state is immediately updated as soon as the map component is mounted, as is done in leaflet/Map.jsx.