Fixes #1006: migrate react-intl to 2.x #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
requested changes
Feb 22, 2017
| @@ -57,7 +58,7 @@ describe('This test for I18N.HTML', () => { | |||
| var currentData = data["it-IT"]; | |||
| var testMsg = currentData.messages[msgId]; | |||
|
|
|||
| const cmp = ReactDOM.render(<I18N.HTML msgId={msgId} messages={ita.messages} locale="it-IT"/>, document.getElementById("container")); | |||
| const cmp = ReactDOM.render(<Localized messages={ita.messages} locale="it-ITE"><I18N.HTML msgId={msgId}/></Localized>, document.getElementById("container")); | |||
mbarto
commented
Feb 22, 2017
| message = message[part]; | ||
| }); | ||
| return <FormattedHTMLMessage locales={locale} message={message} {...this.props.msgParams}/>; | ||
| return this.context.intl ? <FormattedHTMLMessage id={this.props.msgId} values={this.props.msgParams}/> : <span>{this.props.msgId || ""}</span>; |
There was a problem hiding this comment.
id is a property of react-intl FormattedHTMLMessage component, not a DOM id
offtherailz
approved these changes
Feb 22, 2017
manisandro
pushed a commit
to sourcepole/MapStore2
that referenced
this pull request
Feb 27, 2017
…t#1495) * Fixes geosolutions-it#1006: migrate react-intl to 2.x * Fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.