Added appEpics #1644
Merged
Added appEpics #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… If Epic's name is the same the one in plugins this will override plugin's one
mbarto
previously requested changes
Mar 27, 2017
| @@ -26,7 +26,7 @@ const {createEpicMiddleware} = require('redux-observable'); | |||
| const SecurityUtils = require('../utils/SecurityUtils'); | |||
| const ListenerEnhancer = require('@carnesen/redux-add-action-listener-enhancer').default; | |||
|
|
|||
| module.exports = (initialState = {defaultState: {}, mobile: {}}, appReducers = {}, plugins, storeOpts) => { | |||
| module.exports = (initialState = {defaultState: {}, mobile: {}}, appReducers = {}, appEpics = {}, plugins, storeOpts) => { | |||
There was a problem hiding this comment.
New arguments at the end, for compatibility reasons, please
There was a problem hiding this comment.
This signature is better. This doesn't break the binding with StandardApp or other apps. I should put it in that place instead of the bottom.
There was a problem hiding this comment.
Binding appEpics wouldn't be possible
offtherailz
requested changes
Mar 27, 2017
| @@ -72,5 +73,11 @@ describe('PluginsUtils', () => { | |||
| expect(desc1.items[0].cfg).toExist(); | |||
|
|
|||
| }); | |||
| it('combineEpics', () => { | |||
| const plugins = {MapSearchPlugin: MapSearchPlugin}; | |||
| const appEpics = {appEpics: (actions$) => actions$}; | |||
There was a problem hiding this comment.
This sounds like an infinite loop. Is not executed but it should. Please remove it.
offtherailz
approved these changes
Mar 27, 2017
offtherailz
dismissed
mbarto’s stale review
as discussed we removed this because is the correct usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull lets pass an object with app specific Epics
If Epic's name, in appEpics, is the same the one in plugins this will override plugin's one