Fix #2321. Keep circle on change #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mbarto
reviewed
Oct 24, 2017
| @@ -144,12 +144,20 @@ class GeometryDetails extends React.Component { | |||
| center.x - this.circle.radius, center.y - this.circle.radius, | |||
| center.x + this.circle.radius, center.y + this.circle.radius | |||
| ]; | |||
|
|
|||
| let coordinates = CoordinatesUtils.calculateCircleCoordinates(center, this.circle.radius, 100); | |||
| if (this.props.geometry && this.props.geometry.projection === "EPSG:4326") { | |||
There was a problem hiding this comment.
Can't we reproject from any projection that is not the current map projection to the current map projection?
There was a problem hiding this comment.
I could try, but don't know if it works, because of #2222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes 2 kind of issues in Advanced Search circle spatial filter:
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
In advanced search, when you try to edit the circle's details, a marker appears on the map instead of circle. When save the changes, the geometry is not valid and so the search produces no results.
What is the new behavior?
Now you can change the details and the geometry remains a circle.
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other information:
The #2222 still exists. So the real geometry used for the filter is not the same of the one drown on the map.