CRS Selector Merge #3798
Merged
CRS Selector Merge #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: baloola <baloola-mu@hotmail.com>
|
WebSocket is not open: readyState 3 (CLOSED) |
align C042_crs with master branch
mbarto
suggested changes
May 29, 2019
| @@ -0,0 +1,12 @@ | |||
| var expect = require('expect'); | |||
There was a problem hiding this comment.
const would be better, instead of var, our style guide rule for this is to avoid using var
| describe('Test crsselector actions', () => { | ||
| it('test input value action', () => { | ||
| let value = 'ESPG:4326'; | ||
| const retVal = setInputValue(value); |
There was a problem hiding this comment.
I would remove value, and directly use 'EPSG:4326' as the setInputValue argument
| @@ -30,6 +30,7 @@ class LeafletMap extends React.Component { | |||
| onClick: PropTypes.func, | |||
| onRightClick: PropTypes.func, | |||
| mapOptions: PropTypes.object, | |||
| limits: PropTypes.limits, | |||
There was a problem hiding this comment.
PropTypes.object, I presume
| @@ -141,9 +141,13 @@ Layers.registerType('wms', { | |||
| urls: urls, | |||
| params: queryParameters, | |||
| tileGrid: new ol.tilegrid.TileGrid({ | |||
| // TODO: custom grid sets with custom extent | |||
There was a problem hiding this comment.
only TODO comments, I don't think this is useful
|
@mbarto I made @allyoucanmap generate a file with icons from master and this new yesterday. I hope it's enough. |
|
@offtherailz yes, if you have generated yesterday should be fine |
offtherailz
approved these changes
May 29, 2019
mbarto
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the new CRS selector feature into master
Issues
URL of RTD document: https://mapstore.readthedocs.io/en/c042_crs/