New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6886: Configurable CSW filters #7220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsuren1
added
enhancement
Priority: High
Good first issue
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
C169-Rennes-Métropole-2019-GeOrchestra
labels
Aug 20, 2021
Closed
1 task
offtherailz
reviewed
Sep 13, 2021
offtherailz
requested changes
Sep 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well. Only one fix:
- In dashboard, the advanced settings for catalog are shown, but the filter is not used.
CSW_filter_Dashboard.mp4
offtherailz
approved these changes
Sep 20, 2021
@ElenaGallo please test this in DEV and let us know if we can backport to 2021.02.xx |
Test passed, @dsuren1 please backport to 2021.02.xx |
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Sep 23, 2021
(cherry picked from commit 68218c3)
offtherailz
pushed a commit
that referenced
this pull request
Sep 24, 2021
offtherailz
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Sep 24, 2021
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds possibility to configure CSW filters from localConfig and from advanced settings of Catalog
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#6886 & #7084
What is the new behavior?
The CSW filter is configurable as below
staticFilter
- filter is always applied, even when search text is NOT PRESENTdynamicFilter
- filter is used when search text is PRESENT and is applied inAND
withstaticFilter
. The template is used with ${searchText} placeholder to append search stringExample
Note:
filter
- For both static and dynamic filter, input only xml element contained within ogc:Filter (i.e. Do not enclose the filter value in ogc:Filter)Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information