[Backport 2022.02.xx] #8591 Fix chart legend ordering matching colorCatagories order (#8592) #8639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es order (geosolutions-it#8592) * 632 fix on widget chart classification * geosolutions-it#8591 Fix chart legend ordering matching colorCatagories order * add comment to explain the changes * added dedicated tests with data unordered and sorted by autoColorOptions.classification * Fix correct sorting when data are not grouped, and when default label is used * Elements reordering for ranging classification type. Refactoring. * Restored grouping by X axis property prior to sorting. * Adjusting data sample to the fact that data is reordered only by a classification attribute. Additional order inside X axis values cannot happen because it may affect order of data appearance for corresponding classifications and change legend order. * Removed data split by X axis value (redundant action) Co-authored-by: Alexander <113525996+alex-fko@users.noreply.github.com> (cherry picked from commit 940b328)
tdipisa
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Backport 2022.02.xx] #8591 Fix chart legend ordering matching colorCatagories order (#8592)