Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2022.02.xx] #8670 Improve clamp to ground label (#8855) #8865

Merged

Conversation

allyoucanmap
Copy link
Contributor

Description

Improve clamp to ground label in 3D style editor.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: translations update

Issue

What is the current behavior?

#8670

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

)

* Update data.en-US.json

* Update data.es-ES.json

* Update data.fr-FR.json

* Update data.de-DE.json

* Update web/client/translations/data.es-ES.json

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>

* change clamp to ground translation based on symbolizer

Co-authored-by: stefano bovio <stefano.bovio@geosolutionsgroup.com>
@allyoucanmap allyoucanmap added this to the 2022.02.02 milestone Dec 7, 2022
@allyoucanmap allyoucanmap self-assigned this Dec 7, 2022
@tdipisa tdipisa merged commit 05d0815 into geosolutions-it:2022.02.xx Dec 7, 2022
@ElenaGallo
Copy link
Contributor

@allyoucanmap @tdipisa On QA the Polygon Type style settings are not highlighted. See the image below:
no highlighted

@offtherailz
Copy link
Member

offtherailz commented Dec 12, 2022

Hi @ElenaGallo . The fix is missing in this PR and it should be this.

#8670 (comment)

@allyoucanmap do you think this part can be ported without any problem?

Let's see if we can finalize this PR for the tomorrow release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants