Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2023.02.xx] Fix #9624 Point cloud shading options (#9666) #9722

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

allyoucanmap
Copy link
Contributor

Description

Backport for #9666 and #9670

This PR includes options to improve the point cloud shading visualization with additional fixes for 3d tiles options in layer settings

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#9624

What is the new behavior?

This PR adds point cloud shading options

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap added enhancement Backport 3D All issues related to the 3D rendering in CesiumJs C027-COMUNE_FI-2023-SUPPORT labels Nov 21, 2023
@allyoucanmap allyoucanmap added this to the 2023.02.01 milestone Nov 21, 2023
@allyoucanmap allyoucanmap self-assigned this Nov 21, 2023
@allyoucanmap allyoucanmap linked an issue Nov 21, 2023 that may be closed by this pull request
6 tasks
@tdipisa tdipisa requested a review from MV88 November 21, 2023 15:25
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two comment as i've noticed this PR has 2 more files.
in case they are needed i'll Approve

@@ -8,8 +8,9 @@

import React from 'react';
import Message from '../I18N/Message';
import InfoPopover from '../widgets/widget/InfoPopover';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is missing in original PR is because stable branch had some missing code due to other PRs not being backported?

@@ -76,6 +76,23 @@
.background-color-var(@theme-vars[main-bg]);
}
}
.form-group-flex {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is missing in original PR is because stable branch had some missing code due to other PRs not being backported?

@MV88 MV88 merged commit 2ae9b16 into geosolutions-it:2023.02.xx Nov 22, 2023
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Nov 22, 2023

@ElenaGallo please test in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs Backport C027-COMUNE_FI-2023-SUPPORT enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point cloud shading options
2 participants