Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9739: Fix - Incorrect connection of the parent table with the map and other widget #9804

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Dec 7, 2023

Description

This PR fix the incorrect connection of parent table with map and other widgets.

NOTE

The reason for creating this PR pointed directly to 2023.02.xx is because the original fix in DEV deals also with traces in the charts widget and the traces changes are not yet backported to stable.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

What is the new behavior?

  • Fixes the connection made to the parent table widget with map and other widgets
  • Fixes multi-selection of maps and layers in the dashboard wizard for Mac as the event key was not handled correctly

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2023.02.02 milestone Dec 7, 2023
@dsuren1 dsuren1 requested a review from MV88 December 7, 2023 14:05
@dsuren1 dsuren1 self-assigned this Dec 7, 2023
@dsuren1 dsuren1 linked an issue Dec 7, 2023 that may be closed by this pull request
1 task
@tdipisa tdipisa requested review from offtherailz and removed request for MV88 December 7, 2023 14:07
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my previous review. I didn't noticed the issue caused by old package-lock.

I see only this discrepancy, only when I connect to map, with table this doesn't happen.

image

@dsuren1
Copy link
Contributor Author

dsuren1 commented Dec 18, 2023

Instead in the PR I have this issue:

image

Please fix.

Looks like it seems to work fine for me. Could you please recheck it. Thanks

Screen.Recording.2023-12-18.at.4.51.50.PM.mov

@dsuren1
Copy link
Contributor Author

dsuren1 commented Dec 18, 2023

Fixed
image

@offtherailz offtherailz merged commit 6810da8 into geosolutions-it:2023.02.xx Dec 18, 2023
6 checks passed
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on QA ? Thank you

@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 20, 2023
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect connection of the parent table with the map and another widget
4 participants