Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2023.02.xx] Fix #9775 Visibility limits not working in 3D for detached layers (#9777) #9812

Merged
merged 2 commits into from
Dec 13, 2023
Merged

[Backport 2023.02.xx] Fix #9775 Visibility limits not working in 3D for detached layers (#9777) #9812

merged 2 commits into from
Dec 13, 2023

Conversation

allyoucanmap
Copy link
Contributor

Description

This PR introduces following changes:

  • ensure correct visibility when a layer is created
  • review visibility workflow of 3D detached layers. The changes are centralizing the add/remove based on visibility inside the Layer.jsx component instead to have specific implementation per layer type
  • compute of the zoom level based on the distance between camera and target point
  • remove a side effect in the visibility limits form that was showing alerts every time the settings panel was opened

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#9775

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap
Fix geosolutions-it#9775 Visibility limits not working in 3D for deta…
577959a 
…ched layers (geosolutions-it#9777)

* Fix geosolutions-it#9775 Visibility limits not working in 3D for detached layers

* requested changes

* udpate zoom from height comment
@allyoucanmap allyoucanmap added bug Backport 3D All issues related to the 3D rendering in CesiumJs C027-COMUNE_FI-2023-SUPPORT labels Dec 13, 2023
@allyoucanmap allyoucanmap added this to the 2023.02.02 milestone Dec 13, 2023
@allyoucanmap allyoucanmap self-assigned this Dec 13, 2023
@allyoucanmap allyoucanmap linked an issue Dec 13, 2023 that may be closed by this pull request
Visibility limits not working in 3D for detached layers #9775
Closed
1 task
@tdipisa tdipisa requested a review from MV88 December 13, 2023 10:51
@tdipisa tdipisa merged commit bf050d7 into geosolutions-it:2023.02.xx Dec 13, 2023
6 checks passed
@tdipisa
Copy link
Member

tdipisa commented Dec 13, 2023

@ElenaGallo please complete tests in QA once deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV88 MV88 MV88 approved these changes

Assignees

@allyoucanmap allyoucanmap

Labels
3D All issues related to the 3D rendering in CesiumJs Backport bug C027-COMUNE_FI-2023-SUPPORT
Projects
None yet
Milestone
2023.02.02
Development

Successfully merging this pull request may close these issues.

Visibility limits not working in 3D for detached layers
3 participants
@allyoucanmap @tdipisa @MV88