Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport 2023.02.xx - Fix #9685 measurements issues and added some enhancements to it (#9809) #9835

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Dec 19, 2023

Description

backport 2023.02.xx - Fix #9685 measurements issues and added some enhancements to it (#9809)

MV88 and others added 2 commits December 19, 2023 10:37
…GeoProcessing tool (geosolutions-it#9691)

* Fix geosolutions-it#9685 Add possibility tyo use vector layers inside Geo_Processing tool

* refactored the way the counter for each tool is handled
* add possibility to configure a wpsUrl to be used as default source in the plugin otherwise the url from the layer will be used

* refactor: moved some utilities in dedicated utils file

* improved feedback in case wpsUrl is missing

* improve feedback also for buffer tool

* better handling misconfigured layer in buffer tool

* Fixed review points

* better clean up of highlighted features
* fixed layer used in intersection process
* fiz zoom to feature when selected

* fix test
…nts to it (geosolutions-it#9809)

* Fix geosolutions-it#9685 measurements issues and added some enhancements to it

* adding some extra tests

* Fixed problems related to measurements and missing ids

* refactor and optimization

* final fixes for vector layers for the click on map action

* fix geodesic circle

* Fix tests
# Conflicts:
#	web/client/epics/widgets.js
#	web/client/reducers/config.js
#	web/client/utils/LayersUtils.js
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If I export a measure as annotation, the buffer operation includes also the points and do not follow the geodesic lines. Istead the export as a layer works well. @tdipisa should we fix this?
    image

image

  • WFS Intersection works well 👍
    image

  • Circle annotation buffer generation looks wrong, but at the end the annoation seems to have a strange behavior in any case. In the video below you can see the annotation (yellow) and the buffer generated (green). The buffer looks wrong, but when I go in editing the circle changes its shape, and the buffer seems to be generated on that shape... maybe this is a bug of the old annotations ?

screencast-localhost_8081-2023.12.21-16_01_44.webm
  • Intersection between annotations and remote layer gives the error "It was not possible to collect the geometry from the layer Annotations - undefined"
screencast-localhost_8081-2023.12.21-16_07_38.webm

@MV88
Copy link
Contributor Author

MV88 commented Jan 8, 2024

@offtherailz this is ready for review, but i have to specify this:

the third point the one related to the intersection issue is resolved, but it remains problematic since there is this issue in geoserver that occurs
image

@tdipisa i think we should focus on fixing it on master (geoserver side probably) and not in the stable branch

@MV88 MV88 requested a review from offtherailz January 8, 2024 14:44
@tdipisa
Copy link
Member

tdipisa commented Jan 8, 2024

@tdipisa i think we should focus on fixing it on master (geoserver side probably) and not in the stable branch

@offtherailz please proceed with the review and then we will discuss this.

@tdipisa tdipisa linked an issue Jan 8, 2024 that may be closed by this pull request
10 tasks
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not replicate anymore the error on the backend, probably fixed by the NG argorithm configuration.
And circle issue looks to be proper of annotations (re-written), not of this PR.

So for me this PR is approved.

@offtherailz offtherailz merged commit ed5c8a7 into geosolutions-it:2023.02.xx Jan 9, 2024
6 checks passed
@offtherailz
Copy link
Member

offtherailz commented Jan 9, 2024

Please @ElenaGallo test in QA as well as it is deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the GeoProcessing tool to work with client side Vector layers as WPS inputs
3 participants