improved getBoundingBox support for skewed/rotated images #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeoTIFFImage doesn't currently factor in skew/rotation when calculating the bounding box. This code updates getBoundingBox to make use of the relevant skew/rotation parameters in the ModelTransformation tag. The new code only runs if a ModelTransformation tag is present. If there isn't one, the code runs as it currently does.
I also added a test using a geotiff I added to https://github.com/geotiff/test-data. It's clipped from a geotiff from Umbra's open data program. The issue that kicked this off is here: stac-utils/stac-layer#61 (comment)
I've attached a screenshot from QGIS illustrating the change:
Thank you for your consideration and please do let me know if there is any feedback or any requested changes. Open to your thoughts :-)
cc @m-mohr @CloudNiner