Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Mongo module to fix GEOT-5492 #1283

Merged
merged 1 commit into from Aug 19, 2016

Conversation

tingold
Copy link
Contributor

@tingold tingold commented Aug 18, 2016

Fixes GEOT-5492 by:
-upgrade version of mongo-java-driver to 3.3.0 in pom.xml
-replacing usages of “ensureIndex” (deprecated) with “createIndex” in various classes
-UnknownHostException not explicitly thrown

Unit tests remain valid and functional tests pass in GeoServer

Fixes GEOT-5492 by:
-upgrade version of mongo-java-driver to 3.3.0 in pom.xml
-replacing usages of “ensureIndex” (deprecated) with “createIndex” in
various classes

Unit tests remain valid and functional tests pass in GeoServer
@tbarsballe
Copy link
Member

Note: MongoDB 3.3 driver is not explicitly backards compatible with MongoDB < 3.0.
Given that the current version of MongoDB is not compatible with the current version of GeoServer without this change, I feel like this change is fine.

However, this is probably not something we want to backport to older versions of GeoTools.

@aaime
Copy link
Member

aaime commented Aug 19, 2016

I just checked what's in Ubuntu 16.04 LTS, the official package is version 2.6.10, meaning this version will still be popular for the next two years. Is there any chance to make the module work for both versions, 2.x and 3.x?

@tbarsballe
Copy link
Member

I took a little bit of a deeper look into this, and it turns out my information is wrong. The 3.3.0 driver is compatible with MongoDB 2.4 and newer.
The old 2.11 driver is only advertised as compatible with MongoDB 2.4 (and older)

Details here: https://docs.mongodb.com/ecosystem/drivers/driver-compatibility-reference/#reference-compatibility-mongodb-java

So this should be backwards compatible. More importantly, the current driver is not compatible with MongoDB 2.6.

@aaime
Copy link
Member

aaime commented Aug 19, 2016

Oh ok, then the upgrade seems like good news :-)

@tbarsballe
Copy link
Member

Just to be sure, I tested the new driver against both MongoDB 2.4.9 and 3.2.9 on Ubuntu 14.04, and it worked fine. So we appear to be safely backwards compatible.

@tbarsballe tbarsballe merged commit 95d8a0e into geotools:master Aug 19, 2016
@dvntucker
Copy link
Contributor

Should we back port this? I'm not sure but it should be compatible with current stable.

@tbarsballe
Copy link
Member

I would hesitate to backport it, if only because driver changes are the sort of thing that seems likely to break existing configurations.

However, Given that the old (2.11) driver is only advertised as compatible with mongodb 2.4 and older, it may be safe to backport this to 2.9.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants