Initial commit JavaFX map module #1638
Conversation
modules/unsupported/javafx/REVIEW.md
Outdated
| @@ -0,0 +1,30 @@ | |||
| # MODULE EXAMPLE | |||
There was a problem hiding this comment.
I think these needs actual values put into it.
modules/unsupported/javafx/pom.xml
Outdated
| The Geotools Project | ||
| http://www.geotools.org/ | ||
|
|
||
| Version: $Id$ |
There was a problem hiding this comment.
Suggest removing this. CVS ain't coming back.
modules/unsupported/javafx/pom.xml
Outdated
| <!-- --> | ||
| <!-- Available profiles are: --> | ||
| <!-- --> | ||
| <!-- nameOfprofile Explantion of what the profile does --> |
There was a problem hiding this comment.
This probably needs actual values plugged in.
| * GeoTools - The Open Source Java GIS Toolkit | ||
| * http://geotools.org | ||
| * | ||
| * (C) 2007-2008, Open Source Geospatial Foundation (OSGeo) |
There was a problem hiding this comment.
Doesn't look like the right year.
| @@ -215,6 +221,7 @@ | |||
| <module>css</module> | |||
| <module>geojsonstore</module> | |||
| <module>polylabel</module> | |||
| <module>javafx</module> | |||
| double toY = to.getY(); | ||
|
|
||
| double xOffset = (toX - fromX); | ||
| double yOffset = (toY - fromY); |
There was a problem hiding this comment.
Not sure these calcs are needed.
| } | ||
|
|
||
| /** | ||
| * Draws a marker on a speficic position. |
| * @param yPosition Marker y coordinate in screen coordinates | ||
| */ | ||
| public void drawMarker(double xPosition, double yPosition) { | ||
| double markerSpan = this.mapCanvas.getWidth() / HUNDRED; |
There was a problem hiding this comment.
May not work well if canvas is not square.
| && e.getY() > (mouseYPosOnClick - DRAGGING_OFFSET)) { | ||
| drawMarker(mouseXPosOnClick, mouseYPosOnClick); | ||
| markerCount++; | ||
| if (markerCount == 2) { |
| zoomLevel--; | ||
| } | ||
| scaleMap(zoomLevel - lastZoomLevel); | ||
| try{ |
|
Thanks for your feedback. I should have fixed most of the things you mentioned with 75885e7 . |
|
Thanks @awoestmann - I am kicking the travis build to confirm it still builds. |
|
I removed the import that caused build to fail, as it was unused anyway. |
|
Thanks, can you fix up the tabs to spaces when you get a chance! |
|
This merge breaks the build on OpenJDK (unless OpenJFX is installed). I have remove |
This commit creates the JavaFX map module.