[GEOT-6050] Upgrade HSQLDB to 2.4.1

[bencaradocdavies]

https://osgeo-org.atlassian.net/browse/GEOT-6050

[aaime]

I think it looks good, but I have a suggestion.

Let's say we have two GeoTools applications running off the gt-epsg-hsql database, one gets upgraded, the other does not. What happens? Is the old format preserved, or hsql updates the on disk format?
I believe it would be safer to bump the version number to 8.6.0.1, here:

geotools/modules/plugin/epsg-hsql/src/main/java/org/geotools/referencing/factory/epsg/ThreadedHsqlEpsgFactory.java

Line 77 in dd12933

public static final Version VERSION = new Version("8.6.0.0");

This would give the newer version a different path, with no chance of conflict.

[bencaradocdavies]

Sure, updated commit force-pushed. Can we also change the capitalisation of the path from /tmp/Geotools to /tmp/GeoTools. This has always bugged me. We still need the VERSION bump for the reasons you described above on case insensitive filesystems.

[bencaradocdavies]

Oh my. I did it to myself. My Geotools to GeoTools change broke the test I added a few days ago. :-(

[bencaradocdavies]

Once more, with feeling.

[aaime]

Yep, looking good and merging

[bencaradocdavies]

Thanks @aaime.

[bencaradocdavies]

If this change reduces the number of CoverageViewTest failures, it should be backported. I will run some test builds.