Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm YSLD and CQL literal color handling [GEOT-5704] #2076

Merged
merged 3 commits into from
Aug 13, 2019

Conversation

jodygarnett
Copy link
Member

@aaime
Copy link
Member

aaime commented Oct 3, 2018

I cannot comment on the substance of the changes, that's for the YSLD moduler maintainer to do, but the Travis failure is legit, the code was not built by maven before doing the PR and has a formatting issue:

[ERROR] Failed to execute goal com.coveo:fmt-maven-plugin:2.4.0:check (default) on project gt-cql: Found 1 non-complying files, failing build -> [Help 1]

@tbarsballe
Copy link
Member

Please rebuild to apply formatting rules and fix the merge conflicts.

Copy link
Member

@smithkm smithkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YSLD changes look good.

@aaime
Copy link
Member

aaime commented May 5, 2019

@jodygarnett what should we do about this one?

@tbarsballe
Copy link
Member

Still failing on the same formatting issue as before:

[ERROR] Found 1 non-complying files, failing build
[ERROR] To fix formatting errors, run "mvn fmt:format"
[ERROR] Non complying file: /home/travis/build/geotools/geotools/modules/library/cql/src/test/java/org/geotools/filter/text/cql2/FilterToCQLTest.java
[INFO] STARTED build of project org.geotools.xsd:gt-xsd-gml2
[INFO] FAILURE build of project org.geotools:gt-cql

Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
@jodygarnett
Copy link
Member Author

Committed the changed formatting, checking GEOT-5704 this PR confirms the issue cannot be reproduced...

@tbarsballe tbarsballe merged commit a1c8821 into geotools:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants