Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.x backport] Regular test, Q&A and MS SQL Server GH-Action workflow #3241

Merged
merged 2 commits into from
Nov 29, 2020

Conversation

mprins
Copy link
Member

@mprins mprins commented Nov 26, 2020

Move MS SQL Server integration testing to a GH-Action workflow (from travis-ci)

  • remove MS SQL Server builds from travis
  • move MS SQL Server scripts to build/ci/mssql/
  • update docs
  • migrate OpenJDK 1.8 and 11 from travis to github actions

backports #3238 and #3236 to 23.x

see also: https://github.com/geotools/geotools/wiki/Migrate-Travis-builds#travis-builds

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.
  • The changes are not breaking the build in downstream projects using SNAPSHOT dependencies, GeoWebCache and GeoServer (there is an automatic PR check verifying this, check this when it turns green).

The following are required only for core and extension modules (they are welcomed, but not required, for unsupported modules):

  • There is an issue in Jira describing the bug/task/new feature (a notable exemptions is, changes not visible to end users). The ticket is for the GeoTools project, if the issue was found elsewhere it's a good practice to link to the origin ticket/issue.
  • The pull request contains changes related to a single objective. If multiple focuses cannot be avoided, each one is in its own commit and has a separate ticket describing it.
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message(s) must be in the form "[GEOT-XYZW] Title of the Jira ticket"
  • New unit tests have been added covering the changes
  • This PR passes all existing unit tests (test results will be reported by Continuous Integration after opening this PR)
  • This PR passes the QA checks (QA checks results will be reported by Continuous Integration after opening this PR)
  • Documentation has been updated accordingly.

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or not applicable.

@mprins mprins marked this pull request as draft November 26, 2020 18:24
…travis-ci)

- remove MS SQL Server builds from travis
- move MS SQL Server scripts to build/ci/mssql/
- update docs

backports #3238 to 23.x
@mprins mprins marked this pull request as ready for review November 27, 2020 14:45
* ci: migrate from travis to github actions
* ci: shorten Linux workflow display name
* ci: Add -Dall to QA check
* ci: add fail at end flag to QA build
@mprins mprins changed the title [23.x backport] MS SQL Server GH-Action workflow [23.x backport] Regular, Q&A and MS SQL Server GH-Action workflow Nov 29, 2020
@mprins mprins changed the title [23.x backport] Regular, Q&A and MS SQL Server GH-Action workflow [23.x backport] Regular test, Q&A and MS SQL Server GH-Action workflow Nov 29, 2020
@mprins mprins merged commit ca85d14 into 23.x Nov 29, 2020
@mprins mprins deleted the online_test_migration_23.x branch November 29, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants